[SPARK-28440][MLLIB][TEST] Use TestingUtils to compare floating point values

[eugen-natucci]

What changes were proposed in this pull request?

Use org.apache.spark.mllib.util.TestingUtils object across MLLIB component to compare floating point values in tests.

How was this patch tested?

build/mvn test - existing tests against updated code.

[srowen]

Looks OK pending tests.

[SparkQA]

Test build #4825 has finished for PR 25191 at commit d0c2ae9.

• This patch fails Scala style tests.
• This patch merges cleanly.
• This patch adds no public classes.

[eugen-natucci]

addressed failed style checks reported by jenkins

[dongjoon-hyun]

Retest this please.

[SparkQA]

Test build #107859 has finished for PR 25191 at commit a1cfc8c.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

This seems to fail in Jenkins environment. Did it pass in your local environment, @eugen-prokhorenko ?

sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: Expected 0.6 and 1.0 to be within 1.0E-6 using absolute tolerance.
	at org.apache.spark.mllib.util.TestingUtils$DoubleWithAlmostEquals.$tilde$eq$eq(TestingUtils.scala:80)
	at org.apache.spark.mllib.fpm.AssociationRulesSuite.$anonfun$new$4(AssociationRulesSuite.scala:88)
	at org.apache.spark.mllib.fpm.AssociationRulesSuite.$anonfun$new$4$adapted(AssociationRulesSuite.scala:88)

Please make this PR pass the Jenkins.

[eugen-natucci]

I don't know how I missed it. For usage in place of a predicate there is a less strict version of the operator (~= returns false without throwing the exception). The patch is underway.

[eugen-natucci]

fixed

[dongjoon-hyun]

Thank you for the swift update!

[dongjoon-hyun]

Retest this please.

[SparkQA]

Test build #107860 has finished for PR 25191 at commit 49a7efb.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[dongjoon-hyun]

+1, LGTM.
Thank you for your first contribution, @eugen-prokhorenko . Welcome to the Apache Spark community.

Merged to master.

[dongjoon-hyun]

@eugen-prokhorenko . What is your Apache JIRA ID? I want to add you to the Apache Spark contributor group and assign SPARK-28440 to you.

[eugen-natucci]

@dongjoon-hyun it's eugenzyx

[eugen-natucci]

thank you

[dongjoon-hyun]

Thank YOU. It's assigned to you. :)

• https://issues.apache.org/jira/browse/SPARK-28440