-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-3652] [SQL] upgrade spark sql hive version to 0.13.1 #2499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ce SessionStat.start changed in hive0.13.1
|
Can one of the admins verify this patch? |
|
QA tests have started for PR 2499 at commit
|
|
QA tests have finished for PR 2499 at commit
|
… user which lead failed
|
@marmbrus, can you test this? |
|
Hi, thanks for working on this. Unfortunately, we can't just upgrade to Hive 0.13.0 as that would break users who are running 0.12.0. Instead, there is already a PR open to support both versions at the same time using a shim layer #2241. It would be great if you could make any comments on the approach there. |
|
Hi , @marmbrus, thanks for your reply. I did not understand the break when upgrade to hive 0.13, in my understanding that sql syntax of hive 0.13 is compatible with 0.12, so for users there is no change. Maybe i am wrong understanding? |
|
The problem is metastore compatibility. Hive 0.13.0 cannot talk to a 0.12.0 metastore. For this reason we'll want to be able to support both in Spark. |
|
Get it, i see in #2241 hive-thriftserver is not enabled, maybe i can make a new PR to cover hive-thriftserver based on this PR(already upgrade hive version of thriftserver to 0.13.1), how do you think? |
|
It would be great to support the thrift server for both 0.12.0 and 0.13.0. Please discuss your design with @liancheng . |
|
ok, thanks. @liancheng, we can refer to the method of #2241 to provide a shim layer for hive-thriftserver to support 0.12 and 0.13, how about your idea? |
|
@scwf A shim layer seems reasonable if we can make clean abstractions. A major issue is that the original |
|
ok, i will have a try to use a shim layer to implement this. |
|
Would it be okay to close this issue for now, and reopen it when you have a draft of the hive server? Thanks! |
Now spark sql hive version is 0.12.0 and do not support 0.13.1 because of some api level changes in hive new version.
Since hive has backwards compatibility, this PR just upgrade the hive version to 0.13.1(compile this PR against 0.12.0 will get error), i think this is ok for users and we also do not need to support different version of hive .
Notes: