Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jun 27, 2019

What changes were proposed in this pull request?

Avoid hard-coded config: spark.sql.globalTempDatabase.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Jun 27, 2019

Test build #106953 has finished for PR 24979 at commit 7ce8e39.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@wangyum wangyum deleted the SPARK-28179 branch June 28, 2019 01:52
lazy val globalTempViewManager: GlobalTempViewManager = {
// System preserved database should not exists in metastore. However it's hard to guarantee it
// for every session, because case-sensitivity differs. Here we always lowercase it to make our
// life easier.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description should be moved to StaticSQLConf

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#28265 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants