[SPARK-28031][PySpark][TEST] Improve doctest on over function of Column #24854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @HyukjinKwon |
viirya
commented
Jun 12, 2019
| :return: a Column | ||
| >>> from pyspark.sql import Window | ||
| >>> window = Window.partitionBy("name").orderBy("age").rowsBetween(-1, 1) |
Member
Author
There was a problem hiding this comment.
Window spec rowsBetween(-1, 1) doesn't match with rank.
|
Test build #106429 has finished for PR 24854 at commit
|
HyukjinKwon
approved these changes
Jun 13, 2019
Member
|
Merged to master and branch-2.4. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jun 13, 2019
## What changes were proposed in this pull request? Just found the doctest on `over` function of `Column` is commented out. The window spec is also not for the window function used there. We should either remove the doctest, or improve it. Because other functions of `Column` have doctest generally, so this PR tries to improve it. ## How was this patch tested? Added doctest. Closes #24854 from viirya/column-test-minor. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit ddf4a50) Signed-off-by: HyukjinKwon <[email protected]>
emanuelebardelli
pushed a commit
to emanuelebardelli/spark
that referenced
this pull request
Jun 15, 2019
## What changes were proposed in this pull request? Just found the doctest on `over` function of `Column` is commented out. The window spec is also not for the window function used there. We should either remove the doctest, or improve it. Because other functions of `Column` have doctest generally, so this PR tries to improve it. ## How was this patch tested? Added doctest. Closes apache#24854 from viirya/column-test-minor. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
## What changes were proposed in this pull request? Just found the doctest on `over` function of `Column` is commented out. The window spec is also not for the window function used there. We should either remove the doctest, or improve it. Because other functions of `Column` have doctest generally, so this PR tries to improve it. ## How was this patch tested? Added doctest. Closes apache#24854 from viirya/column-test-minor. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit ddf4a50) Signed-off-by: HyukjinKwon <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
## What changes were proposed in this pull request? Just found the doctest on `over` function of `Column` is commented out. The window spec is also not for the window function used there. We should either remove the doctest, or improve it. Because other functions of `Column` have doctest generally, so this PR tries to improve it. ## How was this patch tested? Added doctest. Closes apache#24854 from viirya/column-test-minor. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit ddf4a50) Signed-off-by: HyukjinKwon <[email protected]>
igreenfield
pushed a commit
to axiomsl/spark
that referenced
this pull request
Nov 4, 2019
## What changes were proposed in this pull request? Just found the doctest on `over` function of `Column` is commented out. The window spec is also not for the window function used there. We should either remove the doctest, or improve it. Because other functions of `Column` have doctest generally, so this PR tries to improve it. ## How was this patch tested? Added doctest. Closes apache#24854 from viirya/column-test-minor. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: HyukjinKwon <[email protected]> (cherry picked from commit ddf4a50) Signed-off-by: HyukjinKwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Just found the doctest on
overfunction ofColumnis commented out. The window spec is also not for the window function used there.We should either remove the doctest, or improve it.
Because other functions of
Columnhave doctest generally, so this PR tries to improve it.How was this patch tested?
Added doctest.