[SPARK-27964][SQL] Move v2 catalog update methods to CatalogV2Util #24813
Conversation
|
Test build #106220 has finished for PR 24813 at commit
|
|
Test build #106221 has finished for PR 24813 at commit
|
|
Thank you for making this first, @rdblue ! |
| properties: Map[String, String], | ||
| changes: Seq[TableChange]): Map[String, String] = { | ||
| applyPropertiesChanges(properties.asJava, changes).asScala.toMap | ||
| } |
There was a problem hiding this comment.
This is a newly added function during migration.
|
|
||
| private def replace( | ||
| struct: StructType, | ||
| fieldNames: Seq[String], |
There was a problem hiding this comment.
Thank you for the update. (This field name is modified based on the recent comment.)
dongjoon-hyun
changed the title
|
Test build #106222 has finished for PR 24813 at commit
|
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
This PR created CatalogV2Util by moving old TestTableCatalog object from test suites to main package org.apache.spark.sql.catalog.v2.utils. We will use this functions to implement V2SessionCatalog. All functions are moved correctly. And, one Scala-version function is added and one parameter is renamed according to the previous comments.
cc @gatorsmile
|
I might need more time to understand the proposed V2SessionCatalog. The code movement in this PR is fine to me. |
|
Thank you, @gatorsmile . |
## What changes were proposed in this pull request? Move methods that implement v2 catalog operations to CatalogV2Util so they can be used in apache#24768. ## How was this patch tested? Behavior is validated by existing tests. Closes apache#24813 from rdblue/SPARK-27964-add-catalog-v2-util. Authored-by: Ryan Blue <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
4 participants
What changes were proposed in this pull request?
Move methods that implement v2 catalog operations to CatalogV2Util so they can be used in #24768.
How was this patch tested?
Behavior is validated by existing tests.