Skip to content

Conversation

@LantaoJin
Copy link
Contributor

What changes were proposed in this pull request?

This is a part of #24774, to reduce the code changes made by that.

How was this patch tested?

Exist UTs.

@LantaoJin
Copy link
Contributor Author

cc @gatorsmile @wangyum

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Jun 5, 2019

Test build #106188 has finished for PR 24803 at commit 3d4b2c3.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member

wangyum commented Jun 5, 2019

retest this please

@SparkQA
Copy link

SparkQA commented Jun 5, 2019

Test build #106197 has finished for PR 24803 at commit 3d4b2c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

LGTM

Thanks! Merged to master.

@gatorsmile gatorsmile closed this in 18834e8 Jun 5, 2019
emanuelebardelli pushed a commit to emanuelebardelli/spark that referenced this pull request Jun 15, 2019
## What changes were proposed in this pull request?

This is a part of apache#24774, to reduce the code changes made by that.

## How was this patch tested?

Exist UTs.

Closes apache#24803 from LantaoJin/SPARK-27899_refactor.

Authored-by: LantaoJin <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants