Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to update zstd-jni library to 1.4.0-1 which improves the level 1 compression speed performance by 6% in most scenarios. The following is the full release note.

How was this patch tested?

Pass the Jenkins.

@SparkQA
Copy link

SparkQA commented May 17, 2019

Test build #105481 has finished for PR 24632 at commit 017841c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Retest this please.

@kiszk
Copy link
Member

kiszk commented May 17, 2019

Looks good to update zstd

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting performance improvement. LGTM

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The license file currently in Spark isn't updated to date with https://github.com/luben/zstd-jni/blob/master/LICENSE in the end date. Shall we update it together?

@SparkQA
Copy link

SparkQA commented May 17, 2019

Test build #105483 has finished for PR 24632 at commit 017841c.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented May 17, 2019

The license looks like the same BSD 2-clause? OK by me.

@dongjoon-hyun
Copy link
Member Author

Thank you for review, @kiszk , @Fokko , @viirya , @srowen .
Yep. The license is the same with the existing one in LICENSE-binary.

@SparkQA
Copy link

SparkQA commented May 17, 2019

Test build #4781 has finished for PR 24632 at commit 017841c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you, guys. Merged to master!

@melin
Copy link

melin commented May 22, 2019

image

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented May 22, 2019

Hi, @melin . Could you write in English? This is mainly for Hadoop 3 profile in Apache Spark. Spark 3.0 will support Hadoop 3.2.0+.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-27755 branch May 22, 2019 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants