[SPARK-27722][SQL] removed the unsed "UnsafeKeyValueSorter" file. #24622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
|
Test build #105435 has finished for PR 24622 at commit
|
Contributor
Author
|
please retest this |
Contributor
Author
|
@HyukjinKwon |
Member
|
retest this please. |
Contributor
|
ok to test |
HyukjinKwon
approved these changes
May 16, 2019
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
Looks good if build and tests pass. I think there's no point of keeping unused private codes in Spark - it just makes us hard to read the codes.
|
Test build #105443 has finished for PR 24622 at commit
|
viirya
approved these changes
May 16, 2019
Member
viirya
left a comment
viirya
left a comment
There was a problem hiding this comment.
The build and tests verify this class is not used. If no special reason to keep it, I think it is fine to remove it.
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@HyukjinKwon , @cloud-fan , @viirya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
removed the unused "UnsafeKeyValueSorter.java" file
How was this patch tested?
Ran Compilation and UT locally.
Please review http://spark.apache.org/contributing.html before opening a pull request.