[SPARK-27687][SS] Rename Kafka consumer cache capacity conf and document caching #24590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @srowen |
|
Test build #105348 has finished for PR 24590 at commit
|
srowen
requested changes
May 13, 2019
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/package.scala
Outdated
Show resolved
Hide resolved
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/package.scala
Show resolved
Hide resolved
|
Test build #105375 has finished for PR 24590 at commit
|
Contributor
Author
|
retest this please |
|
Test build #105377 has finished for PR 24590 at commit
|
srowen
approved these changes
May 15, 2019
dongjoon-hyun
approved these changes
May 15, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @gaborgsomogyi and @srowen , @HeartSaVioR .
Merged to master.
dongjoon-hyun
changed the title
|
@gaborgsomogyi @SparkQA , can anyone help me whats wrong here https://stackoverflow.com/questions/58456939/how-to-set-spark-consumer-cache-to-fix-kafkaconsumer-cache-hitting-max-capaci |
Contributor
Author
|
@BdLearnerr I've answered but next time please use the mailing list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Kafka related Spark parameters has to start with
spark.kafka.and not withspark.sql.. Because of this I've renamedspark.sql.kafkaConsumerCache.capacity.Since Kafka consumer caching is not documented I've added this also.
How was this patch tested?
Existing + added unit test.
and manual webpage check.