-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-27682][CORE][GRAPHX][MLLIB] Replace use of collections and methods that will be removed in Scala 2.13 with work-alikes #24586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"pop" the first element
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
Outdated
Show resolved
Hide resolved
|
Test build #105333 has finished for PR 24586 at commit
|
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
Outdated
Show resolved
Hide resolved
mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #105334 has finished for PR 24586 at commit
|
|
Test build #105335 has finished for PR 24586 at commit
|
|
Test build #105336 has finished for PR 24586 at commit
|
MaxGekk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Another non breaking thing to migrate is: |
|
|
…2.13 with work-alikes
|
Test build #105394 has finished for PR 24586 at commit
|
|
BTW I worked around |
|
Merged to master |
What changes were proposed in this pull request?
This replaces use of collection classes like
MutableListandArrayStackwith workalikes that are available in 2.12, as they will be removed in 2.13. It also removes use of.to[Collection]as its uses was superfluous anyway. Removingcollection.breakOutwill have to wait until 2.13How was this patch tested?
Existing tests