Skip to content

[SPARK-27563][FOLLOWUP] Fix to download new release from dist.apache.org #24544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[SPARK-27563][FOLLOWUP] Fix to download new release from dist.apache.org #24544

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfb251b
Unable to download Spark 2.4.3
wangyum May 7, 2019
5e09e5b
Add releaseMirror
wangyum May 7, 2019
cf946e7
Fix mirror
wangyum May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
case _: Exception => None
}
}
val sites = mirrors.distinct :+ "https://archive.apache.org/dist"
val sites =
mirrors.distinct :+ "https://archive.apache.org/dist" :+ PROCESS_TABLES.releaseMirror
logInfo(s"Trying to download Spark $version from $sites")
for (site <- sites) {
val filename = s"spark-$version-bin-hadoop2.7.tgz"
Expand Down Expand Up @@ -210,11 +211,12 @@ class HiveExternalCatalogVersionsSuite extends SparkSubmitTestUtils {
}

object PROCESS_TABLES extends QueryTest with SQLTestUtils {
val releaseMirror = "https://dist.apache.org/repos/dist/release"
// Tests the latest version of every release line.
val testingVersions: Seq[String] = {
import scala.io.Source
try {
Source.fromURL("https://dist.apache.org/repos/dist/release/spark/").mkString
Source.fromURL(s"${releaseMirror}/spark").mkString
Copy link
Contributor

@beliefer beliefer May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe $releaseMirror is better.

Copy link
Member

@dongjoon-hyun dongjoon-hyun May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@srowen srowen May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're picking nits and you change it again, it's not really a mirror. It's the primary dist server. asfDist or something.

.split("\n")
.filter(_.contains("""<li><a href="spark-"""))
.map("""<a href="spark-(\d.\d.\d)/">""".r.findFirstMatchIn(_).get.group(1))
Expand Down