[SPARK-27579][SQL] remove BaseStreamingSource and BaseStreamingSink #24471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #104940 has finished for PR 24471 at commit
|
Member
|
cc @jose-torres Please help review this PR. |
Contributor
|
lgtm |
|
Test build #105140 has finished for PR 24471 at commit
|
Contributor
Author
|
thanks, merging to master! |
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 6, 2019
## What changes were proposed in this pull request? `BaseStreamingSource` and `BaseStreamingSink` is used to unify v1 and v2 streaming data source API in some code paths. This PR removes these 2 interfaces, and let the v1 API extend v2 API to keep API compatibility. The motivation is apache#24416 . We want to move data source v2 to catalyst module, but `BaseStreamingSource` and `BaseStreamingSink` are in sql/core. ## How was this patch tested? existing tests Closes apache#24471 from cloud-fan/streaming. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
BaseStreamingSourceandBaseStreamingSinkis used to unify v1 and v2 streaming data source API in some code paths.This PR removes these 2 interfaces, and let the v1 API extend v2 API to keep API compatibility.
The motivation is #24416 . We want to move data source v2 to catalyst module, but
BaseStreamingSourceandBaseStreamingSinkare in sql/core.How was this patch tested?
existing tests