Skip to content

[SPARK-3578] Fix upper bound in GraphGenerators.sampleLogNormal #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-3578] Fix upper bound in GraphGenerators.sampleLogNormal #2439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1638598
Round down in sampleLogNormal to guarantee upper bound
ankurdave Sep 17, 2014
6fd5fb1
Run sampleLogNormal bounds check 1000 times
ankurdave Sep 20, 2014
5900c22
Round X in loop condition
ankurdave Sep 20, 2014
f6655e5
Go back to math.floor
ankurdave Sep 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ object GraphGenerators {
val Z = rand.nextGaussian()
X = math.exp(mu + sigma*Z)
}
math.round(X.toFloat)
math.floor(X).toInt
}

/**
Expand Down
7 changes: 5 additions & 2 deletions graphx/src/test/scala/org/apache/spark/graphx/util/GraphGeneratorsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,11 @@ class GraphGeneratorsSuite extends FunSuite with LocalSparkContext {
val sigma = 1.3
val maxVal = 100

val dstId = GraphGenerators.sampleLogNormal(mu, sigma, maxVal)
assert(dstId < maxVal)
val trials = 1000
for (i <- 1 to trials) {
val dstId = GraphGenerators.sampleLogNormal(mu, sigma, maxVal)
assert(dstId < maxVal)
}

val dstId_round1 = GraphGenerators.sampleLogNormal(mu, sigma, maxVal, 12345)
val dstId_round2 = GraphGenerators.sampleLogNormal(mu, sigma, maxVal, 12345)
Expand Down