[SPARK-27419][Core]Avoid casting heartbeat interval to seconds (2.4) #24329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
approved these changes
Apr 9, 2019
|
Test build #104447 has finished for PR 24329 at commit
|
|
Test build #104451 has finished for PR 24329 at commit
|
Contributor
|
thanks, merging to 2.4! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 10, 2019
## What changes were proposed in this pull request? Right now as we cast the heartbeat interval to seconds, any value less than 1 second will be casted to 0. This PR just backports the changes of the heartbeat interval in #22473 from master. ## How was this patch tested? Jenkins Closes #24329 from zsxwing/SPARK-27419. Authored-by: Shixiong Zhu <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Member
|
I'm going to open another change to add a note to the migration guide about this. Together with SPARK-27198, this could mean that users with values like "30" for this conf must fix that value or else it won't work at all. |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 22, 2019
…Interval change to migration guide Add note about spark.executor.heartbeatInterval change to migration guide See also #24329 N/A Closes #24432 from srowen/SPARK-27419.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d4a16f4) Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? Right now as we cast the heartbeat interval to seconds, any value less than 1 second will be casted to 0. This PR just backports the changes of the heartbeat interval in apache#22473 from master. ## How was this patch tested? Jenkins Closes apache#24329 from zsxwing/SPARK-27419. Authored-by: Shixiong Zhu <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
…Interval change to migration guide Add note about spark.executor.heartbeatInterval change to migration guide See also apache#24329 N/A Closes apache#24432 from srowen/SPARK-27419.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d4a16f4) Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 25, 2019
## What changes were proposed in this pull request? Right now as we cast the heartbeat interval to seconds, any value less than 1 second will be casted to 0. This PR just backports the changes of the heartbeat interval in apache#22473 from master. ## How was this patch tested? Jenkins Closes apache#24329 from zsxwing/SPARK-27419. Authored-by: Shixiong Zhu <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 25, 2019
…Interval change to migration guide Add note about spark.executor.heartbeatInterval change to migration guide See also apache#24329 N/A Closes apache#24432 from srowen/SPARK-27419.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d4a16f4) Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? Right now as we cast the heartbeat interval to seconds, any value less than 1 second will be casted to 0. This PR just backports the changes of the heartbeat interval in apache#22473 from master. ## How was this patch tested? Jenkins Closes apache#24329 from zsxwing/SPARK-27419. Authored-by: Shixiong Zhu <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
…Interval change to migration guide Add note about spark.executor.heartbeatInterval change to migration guide See also apache#24329 N/A Closes apache#24432 from srowen/SPARK-27419.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d4a16f4) Signed-off-by: Wenchen Fan <[email protected]>
yoock
pushed a commit
to yoock/spark-apache
that referenced
this pull request
Jan 14, 2020
…Interval change to migration guide Add note about spark.executor.heartbeatInterval change to migration guide See also apache/spark#24329 N/A Closes #24432 from srowen/SPARK-27419.2. Authored-by: Sean Owen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d4a16f4) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now as we cast the heartbeat interval to seconds, any value less than 1 second will be casted to 0. This PR just backports the changes of the heartbeat interval in #22473 from master.
How was this patch tested?
Jenkins