Skip to content

[SPARK-27338][CORE][FOLLOWUP] remove trailing space #24289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-27338][CORE][FOLLOWUP] remove trailing space #24289

wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Apr 4, 2019

What changes were proposed in this pull request?

#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 4, 2019

cc @venkata91 @srowen

@venkata91
Copy link
Contributor

venkata91 commented Apr 4, 2019 •
edited
Loading

Interesting. Somehow I missed it.

venkata91
venkata91 approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@venkata91 venkata91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 4, 2019

since it has passed the code style check, I'm merging it, thanks!

@cloud-fan cloud-fan closed this in b56e433 Apr 4, 2019
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 4, 2019

Hi, @cloud-fan . branch-2.4 fails with the same reason~ Could you fix that too, please?

========================================================================
Running Java style checks
========================================================================
Checkstyle failed at following occurrences:
[error] Checkstyle error found in /home/jenkins/workspace/spark-branch-2.4-test-sbt-hadoop-2.7/core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:589: No trailing whitespace allowed.
[error] 1 issue(s) found in Checkstyle report: /home/jenkins/workspace/spark-branch-2.4-test-sbt-hadoop-2.7/core/target/checkstyle-output.xml
[error] running /home/jenkins/workspace/spark-branch-2.4-test-sbt-hadoop-2.7/dev/sbt-checkstyle ; received return code 1

cloud-fan added a commit that referenced this pull request Apr 4, 2019
@cloud-fan
[SPARK-27338][CORE][FOLLOWUP] remove trailing space
af0a4bb 
## What changes were proposed in this pull request?

#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

## How was this patch tested?

N/A

Closes #24289 from cloud-fan/fix.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
cloud-fan added a commit that referenced this pull request Apr 4, 2019
@cloud-fan
[SPARK-27338][CORE][FOLLOWUP] remove trailing space
b95a58e 
## What changes were proposed in this pull request?

#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

## How was this patch tested?

N/A

Closes #24289 from cloud-fan/fix.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Apr 4, 2019

thanks for reminding! backported to 2.4/2.3

@SparkQA
Copy link

SparkQA commented Apr 4, 2019

Test build #104268 has finished for PR 24289 at commit f0a0b9f.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 4, 2019

Thanks!

kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
@cloud-fan @kai-chi
[SPARK-27338][CORE][FOLLOWUP] remove trailing space
211aa61 
## What changes were proposed in this pull request?

apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

## How was this patch tested?

N/A

Closes apache#24289 from cloud-fan/fix.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 25, 2019
@cloud-fan @kai-chi
[SPARK-27338][CORE][FOLLOWUP] remove trailing space
4714e02 
## What changes were proposed in this pull request?

apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

## How was this patch tested?

N/A

Closes apache#24289 from cloud-fan/fix.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
@cloud-fan @kai-chi
[SPARK-27338][CORE][FOLLOWUP] remove trailing space
793cb7b 
## What changes were proposed in this pull request?

apache#24265 breaks the lint check, because it has trailing space. (not sure why it passed jenkins). This PR fixes it.

## How was this patch tested?

N/A

Closes apache#24289 from cloud-fan/fix.

Authored-by: Wenchen Fan <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@venkata91 venkata91 venkata91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cloud-fan @venkata91 @dongjoon-hyun @SparkQA