-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-27354][SQL] Move incompatible code from the hive-thriftserver module to sql/hive-thriftserver/v1.2.1 #24282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #104246 has finished for PR 24282 at commit
|
|
Test build #104247 has finished for PR 24282 at commit
|
|
Test build #104249 has finished for PR 24282 at commit
|
|
retest this please |
|
Test build #104288 has finished for PR 24282 at commit
|
|
Test build #104293 has finished for PR 24282 at commit
|
|
Just thinking out loud, but instead of a whole new module, how different is it from v1? is this accomplishable with profiles and possibly alternate source trees in the current module? Eventually 'v1' goes away so I'm hesitant to 'rename' the current long-term one. |
|
retest this please |
|
Had an offline discussion with @wangyum . Let us try to avoid adding a new module. |
|
Test build #104868 has finished for PR 24282 at commit
|
|
retest this please |
|
Test build #105382 has finished for PR 24282 at commit
|
gatorsmile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please submit the followup PR to show the actual changes.
Thanks, merged to master!
What changes were proposed in this pull request?
When we upgraded the built-in Hive to 2.3.4, the current
hive-thriftservermodule is not compatible, such as these Hive changes:So this PR moves the incompatible code to
sql/hive-thriftserver/v1.2.1and copies it tosql/hive-thriftserver/v2.3.4for the next code review.How was this patch tested?
manual tests: