Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

abstract some common code into a method.

How was this patch tested?

existing tests

@cloud-fan
Copy link
Contributor Author

cc @dilipbiswal

@dilipbiswal
Copy link
Contributor

LGTM
Thanks a lot for doing this @cloud-fan

@SparkQA
Copy link

SparkQA commented Apr 3, 2019

Test build #104243 has finished for PR 24281 at commit cf68e6c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 3, 2019

Test build #104244 has finished for PR 24281 at commit d5a17e9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

thanks, merging to master!

@cloud-fan cloud-fan closed this in ffb362a Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants