-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-26856][PYSPARK][FOLLOWUP] Fix UT failure due to wrong patterns for Kinesis assembly #24268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @HyukjinKwon and @gaborgsomogyi . |
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for catching this. |
|
Thank you for review and approval, @HyukjinKwon . |
|
Test build #104178 has finished for PR 24268 at commit
|
|
Hey @dongjoon-hyun, just to doubly sure, can you check Avro ones as well? |
|
Ah, thank you so much, @HyukjinKwon . |
|
Test build #104181 has finished for PR 24268 at commit
|
|
Test build #104182 has finished for PR 24268 at commit
|
|
Merged to master. |
|
Thank you for review and merging, @HyukjinKwon ! |
|
Late LGTM, thank you @dongjoon-hyun for fixing this. |
What changes were proposed in this pull request?
After SPARK-26856,
KinesisPython UT fails withFound multiple JARsexception due to a wrong pattern.It's because the pattern was changed in a wrong way.
Original
After SPARK-26856
The actual kinesis assembly jar files look like the followings.
SBT Build
MAVEN Build
In addition, after SPARK-26856, the utility function
search_jaris shared to findavrojar files which are identical for bothsbtandmvn. To sum up, The current jar pattern parameter cannot handle bothkinesisandavrojars. This PR splits the single pattern into two patterns.How was this patch tested?
Manual. Please note that this will remove only
Found multiple JARsexception. Kinesis tests need more configurations to run locally.