Skip to content

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Mar 26, 2019

What changes were proposed in this pull request?

This is a follow-up of #23169.
We should've used string-interpolation to show the config key in the warn message.

How was this patch tested?

Existing tests.

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueshin
Copy link
Member Author

ueshin commented Mar 26, 2019

cc @DaveDeCaprio @vanzin

@SparkQA
Copy link

SparkQA commented Mar 26, 2019

Test build #103947 has finished for PR 24217 at commit 5683145.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Mar 26, 2019

Test build #103956 has finished for PR 24217 at commit 5683145.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants