-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-27215][CORE] Correct the kryo configurations #24156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@vanzin @squito @gatorsmile, could you have a time to review this? |
attilapiros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have checked the typo was introduced by #23532 which went into 3.0.0-SNAPSHOT and anyway the whole Kryo pool (along with this config) was introduced only in 3.0.0-SNAPSHOT.
Moreover there is no more reference to the incorrect spelling:
attilapiros@apiros-MBP ~/github/spark (pr/24156) $ find . \( -name "*.scala" -or -name "*.java" \) -exec grep -i "kyro" \{} \; -print
attilapiros@apiros-MBP ~/github/spark (pr/24156) $
gaborgsomogyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Does this change means the previous config key will no longer be recognized? |
The "previous" config key never existed, it was a typo in a recent change. |
Thanks, sounds good! |
|
cc @HeartSaVioR |
HeartSaVioR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for fixing my missed spots.
|
Test build #4642 has finished for PR 24156 at commit
|
|
Merging to master. |
What changes were proposed in this pull request?
kyro should be kryo
How was this patch tested?
no need