Skip to content

Conversation

@LantaoJin
Copy link
Contributor

What changes were proposed in this pull request?

val KRYO_USE_UNSAFE = ConfigBuilder("spark.kyro.unsafe")
    .booleanConf
    .createWithDefault(false)

  val KRYO_USE_POOL = ConfigBuilder("spark.kyro.pool")
    .booleanConf
    .createWithDefault(true)

kyro should be kryo

How was this patch tested?

no need

@LantaoJin
Copy link
Contributor Author

@vanzin @squito @gatorsmile, could you have a time to review this?

Copy link
Contributor

@attilapiros attilapiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I have checked the typo was introduced by #23532 which went into 3.0.0-SNAPSHOT and anyway the whole Kryo pool (along with this config) was introduced only in 3.0.0-SNAPSHOT.

Moreover there is no more reference to the incorrect spelling:

attilapiros@apiros-MBP ~/github/spark (pr/24156) $ find  . \( -name "*.scala" -or -name "*.java" \) -exec grep -i "kyro" \{} \; -print
attilapiros@apiros-MBP ~/github/spark (pr/24156) $

Copy link
Contributor

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jiangxb1987
Copy link
Contributor

Does this change means the previous config key will no longer be recognized?

@vanzin
Copy link
Contributor

vanzin commented Mar 20, 2019

Does this change means the previous config key will no longer be recognized?

The "previous" config key never existed, it was a typo in a recent change.

@jiangxb1987
Copy link
Contributor

Does this change means the previous config key will no longer be recognized?

The "previous" config key never existed, it was a typo in a recent change.

Thanks, sounds good!

@dongjoon-hyun
Copy link
Member

cc @HeartSaVioR

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing my missed spots.

@SparkQA
Copy link

SparkQA commented Mar 20, 2019

Test build #4642 has finished for PR 24156 at commit 616c8ce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor

vanzin commented Mar 20, 2019

Merging to master.

@vanzin vanzin closed this in 93c6d2a Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants