Skip to content

Conversation

@LantaoJin
Copy link
Contributor

@LantaoJin LantaoJin commented Mar 14, 2019

What changes were proposed in this pull request?

A sub-task of SPARK-23206
Add Executor level metrics to monitoring docs

How was this patch tested?

jekyll

@LantaoJin LantaoJin changed the title [SPARK-27157][DOCS] Add Executor level metrics to monitoring doc [SPARK-27157][DOCS] Add Executor level metrics to monitoring docs Mar 14, 2019
<td>Elapsed time the JVM spent in garbage collection summed in this Executor.
The value is expressed in milliseconds.</td>
</tr>
</tr>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two </tr>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@srowen
Copy link
Member

srowen commented Mar 14, 2019

This is probably OK, but are these metrics things that Spark generates or that are generated automatically by Ganglia et al? that is, do we need to document them or point at existing external docs?

@SparkQA
Copy link

SparkQA commented Mar 14, 2019

Test build #4620 has finished for PR 24090 at commit 4049689.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@LucaCanali
Copy link
Contributor

This looks to me a useful addition to the monitoring documentation.
An additional comment is that ProcessTree executor metrics are collected only under certain conditions. I was thinking that maybe this fact can be documented in this PR?
As far as I can see the conditions are the logical AND of the folloving: /proc filesystem exists, spark.eventLog.logStageExecutorProcessTreeMetrics.enabled=true, spark.eventLog.logStageExecutorMetrics.enabled=true

@LantaoJin
Copy link
Contributor Author

This is probably OK, but are these metrics things that Spark generates or that are generated automatically by Ganglia et al? that is, do we need to document them or point at existing external docs?

@srowen They are generated by Spark, see ExecutorMetricType

@LantaoJin
Copy link
Contributor Author

Thank you @LucaCanali, I've added this metrics collection condition.

@SparkQA
Copy link

SparkQA commented Mar 16, 2019

Test build #4630 has finished for PR 24090 at commit 4779f7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen srowen closed this in 6a6075a Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants