[SPARK-27132][SQL] Improve file source V2 framework #24066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@cloud-fan @dongjoon-hyun @HyukjinKwon This PR is the "non-csv-datasource" part of #24005. It contains several improvements. |
|
Test build #103368 has finished for PR 24066 at commit
|
Member
|
Could you rebase this to the master, @gengliangwang ? |
gengliangwang
force-pushed
the
reviseFileSourceV2
branch
from
34c1ce6 to
144b076
Compare
|
Test build #103488 has finished for PR 24066 at commit
|
cloud-fan
reviewed
Mar 14, 2019
| s"Unable to infer schema for $name. It must be specified manually.") | ||
| }.asNullable | ||
|
|
||
| override def schema(): StructType = { |
Contributor
There was a problem hiding this comment.
shall we make this a lazy val? It becomes expensive now.
|
Test build #103498 has finished for PR 24066 at commit
|
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During the migration of CSV V2(#24005), I find that we can improve the file source v2 framework by:
SupportsPushDownFiltersfrom FileScanBuilderisSplitablemight require data source options. Add a new memberoptionsto FileScan.FileTable.schemaa lazy value instead of a method.How was this patch tested?
Unit test