Skip to content

[SPARK-27125][SQL][Test]Add test suite for sql execution page #24052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SPARK-27125][SQL][Test]Add test suite for sql execution page #24052

wants to merge 2 commits into from

Conversation

@shahidki31
Copy link
Contributor

What changes were proposed in this pull request?

Added test suite for AllExecutionsPage class. Checked the scenarios for SPARK-27019 and SPARK-27075.

How was this patch tested?

Added UT, manually tested

@shahidki31
Copy link
Contributor Author

Ok to test

@shahidki31 shahidki31 changed the title [SPARK-27125][Test]Add test suite for sql execution page [SPARK-27125][SQL][Test]Add test suite for sql execution page Mar 11, 2019
@SparkQA
Copy link

SparkQA commented Mar 11, 2019

Test build #103316 has finished for PR 24052 at commit 851637b.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class AllExecutionsPageSuite extends SharedSQLContext

@shahidki31
Copy link
Contributor Author

cc @vanzin @srowen Kindly review

@SparkQA
Copy link

SparkQA commented Mar 11, 2019

Test build #103317 has finished for PR 24052 at commit aae0164.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Mar 12, 2019

Merged to master

@srowen srowen closed this in 1853db3 Mar 12, 2019
@shahidki31
Copy link
Contributor Author

Thanks @srowen @HyukjinKwon

@shahidki31 shahidki31 deleted the SPARK-27125 branch March 12, 2019 17:40
07ARB added a commit to 07ARB/spark that referenced this pull request Oct 23, 2019
@07ARB
[SPARK-29571][SQL][TESTS][FOLLOWUP]Fix UT in AllExecutionsPageSuite c…
cce2fcc 
…lass

 ###What changes were proposed in this pull request?
 This is a follow-up of apache#24052 to correct assert condition.

 ###Why are the changes needed?
 To test IllegalArgumentException condition..

 ###Does this PR introduce any user-facing change?
 No.

 ###How was this patch tested?
 Manual Test (during fixing of SPARK-29453 find this issue)

Author: 07ARB <[email protected]>
@07ARB 07ARB mentioned this pull request Oct 23, 2019
Closed
HyukjinKwon pushed a commit that referenced this pull request Oct 24, 2019
@07ARB @HyukjinKwon
[SPARK-29571][SQL][TESTS][FOLLOWUP] Fix UT in AllExecutionsPageSuite
55ced9c 
### What changes were proposed in this pull request?

This is a follow-up of #24052 to correct assert condition.

### Why are the changes needed?
 To test IllegalArgumentException condition..

### Does this PR introduce any user-facing change?
 No.

### How was this patch tested?

Manual Test (during fixing of SPARK-29453 find this issue)

Closes #26234 from 07ARB/SPARK-29571.

Authored-by: 07ARB <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
@yaooqinn yaooqinn mentioned this pull request Apr 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shahidki31 @SparkQA @srowen @HyukjinKwon