Skip to content

Conversation

@10110346
Copy link
Contributor

@10110346 10110346 commented Mar 7, 2019

What changes were proposed in this pull request?

Subquery Reuse and Exchange Reuse are not the same feature, if we don't want to reuse subqueries,and we just want to reuse exchanges,only one configuration that cannot be done.

This PR adds a new configuration spark.sql.subquery.reuse to control subqueryReuse.

How was this patch tested?

N/A

@10110346 10110346 changed the title [MINOR][SQL]Added a conf to control subqueryReuse [MINOR][SQL]Add a conf to control subqueryReuse Mar 7, 2019
@SparkQA
Copy link

SparkQA commented Mar 7, 2019

Test build #103116 has finished for PR 23998 at commit d468c7f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Mar 7, 2019

Could you please file a jira cuz this pr adds a new config?

@10110346
Copy link
Contributor Author

10110346 commented Mar 7, 2019

Could you please file a jira cuz this pr adds a new config?

Ok,thanks

@10110346 10110346 changed the title [MINOR][SQL]Add a conf to control subqueryReuse [SPARK-27083][SQL]Add a new conf to control subqueryReuse Mar 7, 2019
@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in fac3110 Mar 27, 2019
gatorsmile added a commit that referenced this pull request Jan 23, 2020
…k.sql.execution.subquery.reuse.enabled

### What changes were proposed in this pull request?
This PR is to rename spark.sql.subquery.reuse to spark.sql.execution.subquery.reuse.enabled

### Why are the changes needed?
Make it consistent and clear.

### Does this PR introduce any user-facing change?
N/A. This is a [new conf added in Spark 3.0](#23998)

### How was this patch tested?
N/A

Closes #27346 from gatorsmile/spark27083.

Authored-by: Xiao Li <[email protected]>
Signed-off-by: Xiao Li <[email protected]>
j-baker pushed a commit to palantir/spark that referenced this pull request Jan 25, 2020
## What changes were proposed in this pull request?
Subquery Reuse and Exchange Reuse are not the same feature, if we don't want to reuse subqueries,and we just want to reuse exchanges,only one configuration that cannot be done.

This PR adds a new configuration `spark.sql.subquery.reuse` to control subqueryReuse.

## How was this patch tested?

N/A

Closes apache#23998 from 10110346/SUBQUERY_REUSE.

Authored-by: liuxian <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants