[MINOR][BUILD] Remove useless add-source #23949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #102968 has finished for PR 23949 at commit
|
Contributor
|
retest this please |
HyukjinKwon
approved these changes
Mar 4, 2019
maropu
approved these changes
Mar 4, 2019
|
Test build #102970 has finished for PR 23949 at commit
|
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The source directory(
sql/hive-thriftserver/v${hive.version.short}/src/main/scala) removed from SPARK-6909 and SPARK-7850. We should also remove theadd-source.It seems that removed this
add-sourcemakes it easier to importsrc/gensource code in IDEA:How was this patch tested?
manual tests