Skip to content

[SPARK-3481][SQL] Removes the evil MINOR HACK #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-3481][SQL] Removes the evil MINOR HACK #2377

wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Sep 13, 2014

This is a follow up of #2352. Now we can finally remove the evil "MINOR HACK", which covered up the eldest bug in the history of Spark SQL (see details here).

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have started for PR 2377 at commit 0869c78.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 13, 2014

QA tests have finished for PR 2377 at commit 0869c78.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class JavaSparkContext(val sc: SparkContext)
    • class TaskCompletionListenerException(errorMessages: Seq[String]) extends Exception
    • class JavaStreamingContext(val ssc: StreamingContext) extends Closeable

@marmbrus
Copy link
Contributor

marmbrus commented Sep 13, 2014

Thanks! Merged.

@asfgit asfgit closed this in 184cd51 Sep 13, 2014
@scwf scwf mentioned this pull request Sep 23, 2014
Closed
asfgit pushed a commit that referenced this pull request Sep 23, 2014
@scwf @marmbrus
[SPARK-3481][SQL] removes the evil MINOR HACK
ae60f8f 
 a follow up of #2377 and #2352, see detail there.

Author: wangfei <[email protected]>

Closes #2505 from scwf/patch-6 and squashes the following commits:

4874ec8 [wangfei] removes the evil MINOR HACK
@liancheng liancheng deleted the remove-evil-minor-hack branch September 24, 2014 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liancheng @SparkQA @marmbrus