[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource manager #23743

HeartSaVioR · 2019-02-07T14:27:04Z

What changes were proposed in this pull request?

This patch makes hardcoded configs in "mesos" module to use ConfigEntry, avoiding issues on mistake like SPARK-26082.

Please note that there're some changes on type while migrating to ConfigEntry: specifically "comma-separated list on a string" becomes "sequence of strings". While SparkConf smoothly handles on the change (comma-separated list on a string is still supported so backward compatible), there're some methods in utility class (mesos package private) to depend on the type change, so this patch also modifies the method signature for them a bit.

How was this patch tested?

Existing tests.

SparkQA · 2019-02-07T14:42:10Z

Test build #102076 has finished for PR 23743 at commit c06795c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when #23743 is not applied and succeeds when #23743 is applied. Closes #23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b4e1d14) Signed-off-by: Dongjoon Hyun <[email protected]>

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when #23743 is not applied and succeeds when #23743 is applied. Closes #23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

dongjoon-hyun · 2019-02-07T17:05:40Z

...esos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackendUtil.scala

@HeartSaVioR .
Why do we change this function signature silently in this Use ConfigEntry ... PR?

This is only used for parsing config value, and we are changing the type of config to Seq[String] instead of comma-separated String cause ConfigEntry will handle it better. Same applies for below methods as well.

Similar change was suggested while working on ConfigEntry for others (don't remember which one was...).

I'm not sure changing them would hurt because the object is mesos package private.

@HeartSaVioR . You should mention that in the PR description at least.

TBH I'm not sure we're requiring to mention every incompatible changes for non-public API, but I'm not strongly against it. I'll add it to the PR description.

Please consider that dealing with arbitrary reviewers who have different views on reviewing is not easy. Similar change was done in other PR without any mention and comment. I'd be happy if we have some rules/policies which are across the community in project, and if it doesn't fall into the case, ideally I'd like to see reviewers just kindly and politely suggest/ask it.

My question was about the mismatch between PR title and content itself. If you feel like that, sorry about that. I must be careful. Maybe, silently was too strong word?

Why do we change this function signature silently in this Use ConfigEntry ... PR?

BTW, why do you think my comment is about incompatible changes?

I'm not sure we're requiring to mention every incompatible changes for non-public API

My question was about the mismatch between PR title and content itself.

I didn't know the reason of the question, and why without reason makes me feeling that I got non-positive reviews. I tried to find the reason behind the comment, and thought you were concerning about method signature change hence incompatible - turned out I was wrong. We would have better understanding of each other when we try to ensure explaining rationalization.

Btw, the rationalization of method signature change is follow: at the first time I thought I have to add new methods with different signatures (maybe overloaded) but another thought in my mind it would end up letting old methods being not used anymore, and reviewers would ask me to remove them. So flatten the steps into one would be changing signature anyway.

Part of the purpose of these small comments, which can vary across reviewers, is that it's a way for all of us to sync on how to handle the small things.

The change to the method seems fine, and isn't part of any API. I don't think it needs to be part of the title as it is in the description, even. Let's conclude there.

dongjoon-hyun · 2019-02-07T17:13:43Z

Could you handle the followings?

MesosClusterScheduler.scala:      v => s"$v -Dspark.mesos.driver.frameworkId=${getDriverFrameworkID(desc)}"
MesosClusterScheduler.scala:        logWarning(s"Unknown spark.mesos.appJar.local.resolution.mode $other, using host.")
MesosSchedulerUtils.scala:    sc.conf.remove("spark.mesos.driver.frameworkId")
MesosSchedulerUtils.scala:    System.clearProperty("spark.mesos.driver.frameworkId")

…" resource manager

HeartSaVioR · 2019-02-07T20:50:31Z

Thanks @dongjoon-hyun for finding missing spots! I addressed review comment.

SparkQA · 2019-02-07T21:04:56Z

Test build #102084 has finished for PR 23743 at commit c2d0e04.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dongjoon-hyun · 2019-02-08T09:17:30Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+      .booleanConf
+      .createWithDefault(false)
+
+  private[spark] val APPLICATION_JAR_LOCAL_RESOLUTION_MODE =


nit. Can we use a shorter name like APP_JAR_LOCAL_RESOLUTION_MODE like APP_STATUS_METRICS_ENABLED?

dongjoon-hyun · 2019-02-08T09:29:20Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

  }

+  private[spark] val CREDENTIAL_PRINCIPAL =
+    ConfigBuilder("spark.mesos.principal")


Do you think we had better have .doc like the previous conf SECRET_FILENAMES at line 50 ~ 56?

dongjoon-hyun · 2019-02-08T09:39:00Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+
+  private[spark] val CONTAINERIZER =
+    ConfigBuilder("spark.mesos.containerizer")
+      .stringConf


Please add .checkValues(Set("docker", "mesos")).

dongjoon-hyun · 2019-02-08T09:46:08Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+
+  private[spark] val ROLE =
+    ConfigBuilder("spark.mesos.role")
+      .stringConf


Please add .checkValues(Set("host", "container")).

Honestly I have no idea about available values. Could you refer where I could find available values? I can't find it in Mesos doc - http://mesos.apache.org/documentation/latest/roles/

Ah looks like you're referring APP_JAR_LOCAL_RESOLUTION_MODE in below comment. I'll address it.

Yes. It seems that I clicked a wrong one.

dongjoon-hyun · 2019-02-08T09:52:51Z

...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala

-        logWarning(s"Unknown spark.mesos.appJar.local.resolution.mode $other, using host.")
+        logWarning(s"Unknown ${config.APPLICATION_JAR_LOCAL_RESOLUTION_MODE} $other, using host.")
        false
      }


If we have checkValue, we can simplify the above logic line 422 ~ 426, too.

dongjoon-hyun · 2019-02-08T09:55:27Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+
+  private[spark] val COARSE_SHUTDOWN_TIMEOUT =
+    ConfigBuilder("spark.mesos.coarse.shutdownTimeout")
+      .timeConf(TimeUnit.MILLISECONDS)


Let's add .checkValue(_ >= 0, "spark.mesos.coarse.shutdownTimeout must be >= 0") here.

dongjoon-hyun · 2019-02-08T09:56:16Z

...main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala

  private[this] val shutdownTimeoutMS =
-    conf.getTimeAsMs("spark.mesos.coarse.shutdownTimeout", "10s")
-      .ensuring(_ >= 0, "spark.mesos.coarse.shutdownTimeout must be >= 0")
+    conf.get(COARSE_SHUTDOWN_TIMEOUT).ensuring(_ >= 0, s"$COARSE_SHUTDOWN_TIMEOUT must be >= 0")


Since we have checkValue in config definition, we can remove this ensuring here.

dongjoon-hyun · 2019-02-08T10:03:19Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+      .stringConf
+      .createWithDefault("")
+
+  private[spark] val SLAVE_OFFER_CONSTRAINTS =


I understand this comes from the variable name slaveOfferConstraints. But, shall we simply use CONSTRAINTS because most Mesos offer configurations are actually about the slave?

dongjoon-hyun · 2019-02-08T10:20:04Z

...scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackendSuite.scala

-    sparkConf.set("spark.driver.host", "driverHost")
-    sparkConf.set("spark.driver.port", "1234")
+    sparkConf.set(DRIVER_HOST_ADDRESS.key, "driverHost")
+    sparkConf.set(DRIVER_PORT.key, "1234")


- sparkConf.set(DRIVER_HOST_ADDRESS.key, "driverHost") - sparkConf.set(DRIVER_PORT.key, "1234") + sparkConf.set(DRIVER_HOST_ADDRESS, "driverHost") + sparkConf.set(DRIVER_PORT, 1234)

dongjoon-hyun

I left a few comments including .doc.

…sClusterScheduler This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied.

dongjoon-hyun · 2019-02-10T18:12:35Z

@clems4ever This PR is almost done. I'm waiting for a few minor .doc additions to sync with documentation.

clems4ever · 2019-02-10T18:22:14Z

Alright @dongjoon-hyun, I'll keep an eye on this PR. Thanks for letting me know.

felixcheung

LG mostly, 2 questions

felixcheung · 2019-02-10T19:08:53Z

...t/scala/org/apache/spark/scheduler/cluster/mesos/MesosFineGrainedSchedulerBackendSuite.scala


  test("Use configured mesosExecutor.cores for ExecutorInfo") {
-    val mesosExecutorCores = 3
+    val mesosExecutorCores = 3.0


why is this change needed?

The type of EXECUTOR_CORES is actually double instead of int or long and if my memory is right compiler complained. If we don't want to touch this we may need to change below line to conf.set(EXECUTOR_CORES.key, mesosExecutorCores.toString)

The type of a number of cores is logically an integer and can be used where a double is expected. In a few cases a cast may be needed but doesn't require thinking of number of cores as a float

I'm honestly not a expert on this but the documentation of spark.mesos.mesosExecutor.cores clarify that it can receive floating point number so the type still makes sense.

https://github.com/apache/spark/blob/master/docs/running-on-mesos.md

<tr> <td><code>spark.mesos.mesosExecutor.cores</code></td> <td><code>1.0</code></td> <td> (Fine-grained mode only) Number of cores to give each Mesos executor. This does not include the cores used to run the Spark tasks. In other words, even if no Spark task is being run, each Mesos executor will occupy the number of cores configured here. The value can be a floating point number. </td> </tr>

The default value is also explained as 1.0 instead of 1. I'll update the config entry to reflect the sync.

Oh right mesos can specify fractional cores. OK this makes sense then.

felixcheung · 2019-02-10T19:21:28Z

...rs/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala

-    ).flatten
+    val confUris = (conf.get(config.URIS_TO_DOWNLOAD) ++
+      desc.conf.get(config.URIS_TO_DOWNLOAD) ++
+      desc.conf.get(SUBMIT_PYTHON_FILES)).toList


I'm not sure this is exactly the same? _.split(",").map(_.trim) - before URIS_TO_DOWNLOAD should be a comma separated list (probably not intentional, but it works) and URIS_TO_DOWNLOAD & SUBMIT_PYTHON_FILES could have whitespaces

Element values will be trimmed as same as it was - ConfigBuilder handles it:

spark/core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala

Lines 123 to 126 in dc46fb7

/** Turns the config entry into a sequence of values of the underlying type. */

def toSequence: TypedConfigBuilder[Seq[T]] = {

new TypedConfigBuilder(parent, stringToSeq(_, converter), seqToString(_, stringConverter))

}

spark/core/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala

Lines 48 to 50 in dc46fb7

def stringToSeq[T](str: String, converter: String => T): Seq[T] = {

Utils.stringToSeq(str).map(converter)

}

spark/core/src/main/scala/org/apache/spark/util/Utils.scala

Lines 2619 to 2621 in dc46fb7

def stringToSeq(str: String): Seq[String] = {

str.split(",").map(_.trim()).filter(_.nonEmpty)

}

HeartSaVioR · 2019-02-10T22:14:41Z

Documentation addressed. Please note that I only copied the contents from Spark Properties table. For others only referred or mentioned I didn't touch them to avoid bad explanation.

SparkQA · 2019-02-10T22:20:53Z

Test build #102162 has finished for PR 23743 at commit e9a180e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2019-02-10T22:28:06Z

Test build #102163 has finished for PR 23743 at commit 7986b0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when #23734 is not applied and succeeds when #23734 is applied. Closes #23753 from HeartSaVioR/SPARK-26082-branch-2.4. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While #23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when #23734 is not applied and succeeds when #23734 is applied. Closes #23754 from HeartSaVioR/SPARK-26082-branch-2.3. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

dongjoon-hyun · 2019-02-10T23:43:58Z

resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala

+    ConfigBuilder("spark.mesos.constraints")
+      .doc("Attribute-based constraints on mesos resource offers. By default, all resource " +
+        "offers will be accepted. This setting applies only to executors. Refer to Mesos " +
+        "Attributes & Resources doc for more information on attributes. " +


Hi, @HeartSaVioR .
Could you remove the followings line 338 ~ 347? Since it says Refer to Mesos ... already, it looks okay to remove the rest.

Totally agreed. Just addressed it.

SparkQA · 2019-02-10T23:59:48Z

Test build #102166 has finished for PR 23743 at commit c5bee33.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

dongjoon-hyun

+1, LGTM. Merged to master.

dongjoon-hyun · 2019-02-11T00:36:36Z

Thank you, @HeartSaVioR , @srowen , @felixcheung !

HeartSaVioR · 2019-02-11T00:39:18Z

Thanks all for reviewing and merging!

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied. Closes apache#23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…" resource manager ## What changes were proposed in this pull request? This patch makes hardcoded configs in "mesos" module to use ConfigEntry, avoiding issues on mistake like SPARK-26082. Please note that there're some changes on type while migrating to ConfigEntry: specifically "comma-separated list on a string" becomes "sequence of strings". While SparkConf smoothly handles on the change (comma-separated list on a string is still supported so backward compatible), there're some methods in utility class (`mesos` package private) to depend on the type change, so this patch also modifies the method signature for them a bit. ## How was this patch tested? Existing tests. Closes apache#23743 from HeartSaVioR/SPARK-26843. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied. Closes apache#23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b4e1d14) Signed-off-by: Dongjoon Hyun <[email protected]>

…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23734 is not applied and succeeds when apache#23734 is applied. Closes apache#23753 from HeartSaVioR/SPARK-26082-branch-2.4. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied. Closes apache#23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b4e1d14) Signed-off-by: Dongjoon Hyun <[email protected]>

…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23734 is not applied and succeeds when apache#23734 is applied. Closes apache#23753 from HeartSaVioR/SPARK-26082-branch-2.4. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

…sClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23743 is not applied and succeeds when apache#23743 is applied. Closes apache#23744 from HeartSaVioR/SPARK-26082-add-unit-test. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b4e1d14) Signed-off-by: Dongjoon Hyun <[email protected]>

…tion on MesosClusterScheduler ## What changes were proposed in this pull request? This patch adds UT on testing SPARK-26082 to avoid regression. While apache#23743 reduces the possibility to make a similar mistake, the needed lines of code for adding tests are not that huge, so I guess it might be worth to add them. ## How was this patch tested? Newly added UTs. Test "supports setting fetcher cache" fails when apache#23734 is not applied and succeeds when apache#23734 is applied. Closes apache#23753 from HeartSaVioR/SPARK-26082-branch-2.4. Authored-by: Jungtaek Lim (HeartSaVioR) <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>

srowen approved these changes Feb 7, 2019

View reviewed changes

HeartSaVioR mentioned this pull request Feb 7, 2019

[SPARK-26082][MESOS][FOLLOWUP] Add UT on fetcher cache option on MesosClusterScheduler #23744

Closed

dongjoon-hyun reviewed Feb 7, 2019

View reviewed changes

HeartSaVioR added 3 commits February 8, 2019 05:43

[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos…

69751cb

…" resource manager

Also apply to the change of commit b4e1d14

c156fe0

Address review comment from dongjoon-hyun

c2d0e04

HeartSaVioR force-pushed the SPARK-26843 branch from c06795c to c2d0e04 Compare February 7, 2019 20:49

dongjoon-hyun reviewed Feb 8, 2019

View reviewed changes

dongjoon-hyun requested changes Feb 8, 2019

View reviewed changes

HeartSaVioR mentioned this pull request Feb 9, 2019

[SPARK-26082][MESOS][FOLLOWUP][BRANCH-2.4] Add UT on fetcher cache option on MesosClusterScheduler #23753

Closed

This was referenced Feb 9, 2019

[SPARK-26082][MESOS][FOLLOWUP][BRANCH-2.3] Add UT on fetcher cache option on MesosClusterScheduler #23754

Closed

[SPARK-26082][MESOS][FOLLOWUP] Fix Scala-2.11 build #23755

Closed

dongjoon-hyun mentioned this pull request Feb 10, 2019

[SPARK-17454][MESOS] Use Mesos disk resources for executors. #23758

Closed

felixcheung reviewed Feb 10, 2019

View reviewed changes

HeartSaVioR added 2 commits February 11, 2019 07:03

Copy documentation on new ConfigEntry from running-mesos.md

e9a180e

Minor sync-up with doc

7986b0d

dongjoon-hyun reviewed Feb 10, 2019

View reviewed changes

Reduce lines in too-way-long doc

c5bee33

dongjoon-hyun approved these changes Feb 11, 2019

View reviewed changes

dongjoon-hyun closed this in af4c59c Feb 11, 2019

HeartSaVioR deleted the SPARK-26843 branch February 11, 2019 00:39

GulajavaMinistudio mentioned this pull request Feb 11, 2019

clean up excess code GulajavaMinistudio/spark#519

Merged

	/** Turns the config entry into a sequence of values of the underlying type. */
	def toSequence: TypedConfigBuilder[Seq[T]] = {
	new TypedConfigBuilder(parent, stringToSeq(_, converter), seqToString(_, stringConverter))
	}

	def stringToSeq[T](str: String, converter: String => T): Seq[T] = {
	Utils.stringToSeq(str).map(converter)
	}

	def stringToSeq(str: String): Seq[String] = {
	str.split(",").map(_.trim()).filter(_.nonEmpty)
	}

[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource manager #23743

[SPARK-26843][MESOS] Use ConfigEntry for hardcoded configs for "mesos" resource manager #23743

Uh oh!

Conversation

HeartSaVioR commented Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

SparkQA commented Feb 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeartSaVioR Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeartSaVioR Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Feb 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HeartSaVioR commented Feb 7, 2019

Uh oh!

SparkQA commented Feb 7, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun Feb 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Feb 10, 2019

Uh oh!

clems4ever commented Feb 10, 2019

Uh oh!

felixcheung left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HeartSaVioR commented Feb 7, 2019 •

edited

Loading

HeartSaVioR Feb 7, 2019 •

edited

Loading

dongjoon-hyun Feb 8, 2019 •

edited

Loading

HeartSaVioR Feb 8, 2019 •

edited

Loading

dongjoon-hyun commented Feb 7, 2019 •

edited

Loading

dongjoon-hyun Feb 8, 2019 •

edited

Loading

dongjoon-hyun Feb 8, 2019 •

edited

Loading

HeartSaVioR Feb 10, 2019 •

edited

Loading