[SPARK-26716][SPARK-26765][FOLLOWUP][SQL] Clean up schema validation methods and override toString method in Avro #23699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
gengliangwang
force-pushed
the
SPARK-26716-followup
branch
from
2052c9f to
5bcb6c5
Compare
|
Test build #101893 has finished for PR 23699 at commit
|
|
Test build #101896 has finished for PR 23699 at commit
|
HyukjinKwon
reviewed
Jan 31, 2019
external/avro/src/main/scala/org/apache/spark/sql/avro/AvroFileFormat.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Jan 31, 2019
cloud-fan
approved these changes
Jan 31, 2019
Contributor
|
retest this please |
|
Test build #101928 has finished for PR 23699 at commit
|
|
Test build #101930 has finished for PR 23699 at commit
|
Contributor
|
thanks, merging to master! |
HyukjinKwon
changed the title
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…methods and override toString method in Avro ## What changes were proposed in this pull request? In apache#23639, the API `supportDataType` is refactored. We should also remove the method `verifyWriteSchema` and `verifyReadSchema` in `DataSourceUtils`. Since the error message use `FileFormat.toString` to specify the data source naming, this PR also overriding the `toString` method in `AvroFileFormat`. ## How was this patch tested? Unit test. Closes apache#23699 from gengliangwang/SPARK-26716-followup. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In #23639, the API
supportDataTypeis refactored. We should also remove the methodverifyWriteSchemaandverifyReadSchemainDataSourceUtils.Since the error message use
FileFormat.toStringto specify the data source naming, this PR also overriding thetoStringmethod inAvroFileFormat.How was this patch tested?
Unit test.