[SPARK-26448][SQL][followup] should not normalize grouping expressions for final aggregate #23692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Jan 30, 2019
Contributor
Author
There was a problem hiding this comment.
A small refactor so that we can retain the alias when normalizing.
Contributor
Author
|
Test build #101872 has finished for PR 23692 at commit
|
Contributor
Author
|
retest this please |
viirya
reviewed
Jan 30, 2019
Member
There was a problem hiding this comment.
Don't we need to remove it from AggUtils.createAggregate?
|
Test build #101879 has finished for PR 23692 at commit
|
viirya
approved these changes
Jan 30, 2019
|
Test build #101886 has finished for PR 23692 at commit
|
gatorsmile
reviewed
Jan 31, 2019
| val stateVersion = conf.getConf(SQLConf.STREAMING_AGGREGATION_STATE_FORMAT_VERSION) | ||
|
|
||
| // Ideally this should be done in `NormalizeFloatingNumbers`, but we do it here because | ||
| // `groupingExpressions` is not extracted during logical phase. |
Member
There was a problem hiding this comment.
This will be refactored after https://issues.apache.org/jira/browse/SPARK-25914?
Member
|
LGTM since the current hack will be removed soon.
…On Wed, Jan 30, 2019 at 11:47 PM Wenchen Fan ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala
<#23692 (comment)>:
> @@ -331,8 +332,17 @@ abstract class SparkStrategies extends QueryPlanner[SparkPlan] {
val stateVersion = conf.getConf(SQLConf.STREAMING_AGGREGATION_STATE_FORMAT_VERSION)
+ // Ideally this should be done in `NormalizeFloatingNumbers`, but we do it here because
+ // `groupingExpressions` is not extracted during logical phase.
yea
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23692 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALCApUDTB69icwWGqz6tjj3FguVL_-ATks5vIp-hgaJpZM4aZix8>
.
|
Contributor
Author
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…s for final aggregate ## What changes were proposed in this pull request? A followup of apache#23388 . `AggUtils.createAggregate` is not the right place to normalize the grouping expressions, as final aggregate is also created by it. The grouping expressions of final aggregate should be attributes which refer to the grouping expressions in partial aggregate. This PR moves the normalization to the caller side of `AggUtils`. ## How was this patch tested? existing tests Closes apache#23692 from cloud-fan/follow. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
A followup of #23388 .
AggUtils.createAggregateis not the right place to normalize the grouping expressions, as final aggregate is also created by it. The grouping expressions of final aggregate should be attributes which refer to the grouping expressions in partial aggregate.This PR moves the normalization to the caller side of
AggUtils.How was this patch tested?
existing tests