Skip to content

[SQL] [Docs] typo fixes #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[SQL] [Docs] typo fixes #2367

wants to merge 2 commits into from

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Sep 12, 2014

  • Fixed random typo
  • Added in missing description for DecimalType

@nchammas
[SQL] [Docs] typo fixes
3247ac1 
* Fixed random typo
* Added in description for BigDecimal
nchammas
nchammas reviewed Sep 12, 2014
View reviewed changes
docs/sql-programming-guide.md Outdated
Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure about this, actually, but the description is obviously missing.

Copy link
Contributor

@marmbrus marmbrus Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Represents arbitrary-precision signed decimal numbers. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale. Backed internally by java.math.BigDecimal.

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean "A DecimalType consists of..."?

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps a reordering of the sentences as such?

Represents arbitrary-precision signed decimal numbers. Backed internally by java.math.BigDecimal. A BigDecimal consists of an arbitrary precision integer unscaled value and a 32-bit integer scale.

Copy link
Contributor

@marmbrus marmbrus Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, either way.

Copy link
Contributor Author

@nchammas nchammas Sep 12, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie doke. Done. (the latter way)

@nchammas
Copy link
Contributor Author

nchammas commented Sep 12, 2014

@marmbrus - These things should probably also be fixed in the just-released 1.1.0 docs:

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have started for PR 2367 at commit 3247ac1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have finished for PR 2367 at commit 3247ac1.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have started for PR 2367 at commit aa528be.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 12, 2014

QA tests have finished for PR 2367 at commit aa528be.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@nchammas
Copy link
Contributor Author

nchammas commented Sep 13, 2014

@marmbrus Is this PR good to go? I'd be happy to update it or close it as required.

@marmbrus
Copy link
Contributor

marmbrus commented Sep 13, 2014

Thanks! Merged.

asfgit pushed a commit that referenced this pull request Sep 13, 2014
@nchammas @marmbrus
[SQL] [Docs] typo fixes
70f93d5 
* Fixed random typo
* Added in missing description for DecimalType

Author: Nicholas Chammas <[email protected]>

Closes #2367 from nchammas/patch-1 and squashes the following commits:

aa528be [Nicholas Chammas] doc fix for SQL DecimalType
3247ac1 [Nicholas Chammas] [SQL] [Docs] typo fixes

(cherry picked from commit a523cea)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in a523cea Sep 13, 2014
@nchammas nchammas deleted the patch-1 branch September 16, 2014 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nchammas @SparkQA @marmbrus