Skip to content

Conversation

@shahidki31
Copy link
Contributor

@shahidki31 shahidki31 commented Jan 21, 2019

What changes were proposed in this pull request?

When we launch an application in yarn client without any hbase related libraries, spark is throwing a misleading exception.

Added a separate warning message for "NoClassFoundException".

How was this patch tested?

Test steps:
bin/spark-shell --master yarn
Before fix:
screenshot from 2019-01-21 23-32-05
screenshot from 2019-01-21 23-34-45

After fix:
screenshot from 2019-01-21 23-22-11

Copy link
Contributor

@HeartSaVioR HeartSaVioR Jan 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike Hadoop and Hive, Spark will not be built with HBase libs. It will only work when end users link the HBase libraries or contain HBase libraries in their app jar.

So the message doesn't look correct, though I think Fail to invoke HBaseConfiguration is more misleading.

Actually the root issue is that HBaseDelegationToken is activated even end users don't use HBase in their apps, which #23499 is trying to avoid with service loader.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I will check the PR

@SparkQA
Copy link

SparkQA commented Jan 21, 2019

Test build #101491 has finished for PR 23605 at commit 2b59fef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Also, please describe how you met this issue, reproducible steps, analysis of the problem and how the PR fixes the PR in JIRA and/or PR.

@shahidki31
Copy link
Contributor Author

@HyukjinKwon The issue is pretty easy to reproduce in the latest code, if we dont give any configs related to hbase, which was not happening previously. Thanks

@HyukjinKwon
Copy link
Member

It's easy to reproduce but I would show what you tried then making people try it by themselves to deduplicate efforts and time. Please fill the details up.

@shahidki31
Copy link
Contributor Author

Thanks @HyukjinKwon . updated

@shahidki31 shahidki31 closed this Jan 22, 2019
@SparkQA
Copy link

SparkQA commented Jan 22, 2019

Test build #101508 has finished for PR 23605 at commit aa6fef9.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants