[SPARK-26640][CORE][ML][SQL][STREAMING][PYSPARK] Code cleanup from lgtm.com analysis #23571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srowen
commented
Jan 17, 2019
|
|
||
| var endPoint = createRESTEndPointForExecutorsPage(appId); | ||
| $.getJSON(endPoint, function (response, status, jqXHR) { | ||
| var summary = []; |
| { | ||
| data: function (row, type) { | ||
| return type === 'display' ? (formatDuration(row.allTotalDuration, type) + ' (' + formatDuration(row.allTotalGCTime, type) + ')') : row.allTotalDuration | ||
| return type === 'display' ? (formatDuration(row.allTotalDuration) + ' (' + formatDuration(row.allTotalGCTime) + ')') : row.allTotalDuration |
| historySummary = $("#history-summary"); | ||
| searchString = historySummary["context"]["location"]["search"]; | ||
| requestedIncomplete = getParameterByName("showIncomplete", searchString); | ||
| var historySummary = $("#history-summary"); |
| "hasMultipleAttempts": hasMultipleAttempts, | ||
| "showCompletedColumns": !requestedIncomplete, | ||
| } | ||
| }; |
Member
Author
There was a problem hiding this comment.
Implicit semicolon -> explicit
| from __future__ import print_function | ||
|
|
||
| from pyspark.sql import SparkSession | ||
| from pyspark.ml.param import Params |
| precision = metrics.precision() | ||
| recall = metrics.recall() | ||
| f1Score = metrics.fMeasure() | ||
| precision = metrics.precision(1.0) |
Member
Author
There was a problem hiding this comment.
Missed this when removing deprecated no-arg method
| conf.put(SparkLauncher.DRIVER_EXTRA_CLASSPATH, value); | ||
| break; | ||
| case CONF: | ||
| checkArgument(value != null, "Missing argument to %s", CONF); |
Member
Author
There was a problem hiding this comment.
Flags that this seems like it wants to check for null as it's check elsewhere
| sock = None | ||
| else: | ||
| raise Exception("could not open socket: %s" % errors) | ||
| raise Exception("could not open socket: %s" % errors) |
Member
Author
There was a problem hiding this comment.
else: with for doesn't do anything different if there's no break
| :return: model instance | ||
| """ | ||
| raise NotImplemented | ||
| raise NotImplementedError |
Member
Author
There was a problem hiding this comment.
NotImplemented is not actually an error that can be thrown
| '"field6":[{"field7": "row2"}]}', | ||
| '{"field1" : null, "field2": "row3", ' | ||
| '"field3":{"field4":33, "field5": []}}' | ||
| '{"field1" : 2, "field3":{"field4":22, "field5": [10, 11]},"field6":[{"field7": "row2"}]}', |
Member
Author
There was a problem hiding this comment.
Confusing string concatenation across lines
|
Test build #101336 has finished for PR 23571 at commit
|
HyukjinKwon
reviewed
Jan 17, 2019
HyukjinKwon
approved these changes
Jan 17, 2019
|
Test build #101337 has finished for PR 23571 at commit
|
HyukjinKwon
reviewed
Jan 17, 2019
Use `numpy.array` instead of `array` in doctests (PR 23571)
|
Test build #101368 has finished for PR 23571 at commit
|
Member
Author
|
Merged to master |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…tm.com analysis ## What changes were proposed in this pull request? Misc code cleanup from lgtm.com analysis. See comments below for details. ## How was this patch tested? Existing tests. Closes apache#23571 from srowen/SPARK-26640. Lead-authored-by: Sean Owen <[email protected]> Co-authored-by: Hyukjin Kwon <[email protected]> Co-authored-by: Sean Owen <[email protected]> Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Misc code cleanup from lgtm.com analysis. See comments below for details.
How was this patch tested?
Existing tests.