[MINOR][BUILD] Remove binary license/notice files in a source release for branch-2.4+ only #23538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
srowen
reviewed
Jan 14, 2019
| rm -r spark-$SPARK_VERSION/licenses-binary | ||
|
|
||
| # For source release in v2.4+, exclude copy of binary license/notice | ||
| if [[ $SPARK_VERSION > "2.4" ]]; then |
Member
There was a problem hiding this comment.
This seems OK, but do the rms cause a problem? if they fail or print an error, add -f? But this is fine too.
Member
Author
There was a problem hiding this comment.
Yea, the script fails and stops for branch-2.3. Both is ok to me, adding -f or checking the version.
Member
There was a problem hiding this comment.
Meh I'd just make this change. I'll merge it.
srowen
approved these changes
Jan 14, 2019
|
Test build #101183 has finished for PR 23538 at commit
|
srowen
pushed a commit
that referenced
this pull request
Jan 15, 2019
… for branch-2.4+ only ## What changes were proposed in this pull request? To skip some steps to remove binary license/notice files in a source release for branch2.3 (these files only exist in master/branch-2.4 now), this pr checked a Spark release version in `dev/create-release/release-build.sh`. ## How was this patch tested? Manually checked. Closes #23538 from maropu/FixReleaseScript. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit abc937b) Signed-off-by: Sean Owen <[email protected]>
Member
|
Merged to master/2.4. @maropu am I right that this change doesn't have to be in 2.3 for you to release 2.3.3? It doesn't pick cleanly and 2.3 doesn't have any of this license logic, so I presume you're not using it. |
Member
Author
|
Yea, we don't need to merge this into branch-2.3. Since the release script can handle releases for both branch-2.4/2.3, I'm just using it in master for preparing the v2.3 release candidate. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
… for branch-2.4+ only ## What changes were proposed in this pull request? To skip some steps to remove binary license/notice files in a source release for branch2.3 (these files only exist in master/branch-2.4 now), this pr checked a Spark release version in `dev/create-release/release-build.sh`. ## How was this patch tested? Manually checked. Closes apache#23538 from maropu/FixReleaseScript. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Sean Owen <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
… for branch-2.4+ only ## What changes were proposed in this pull request? To skip some steps to remove binary license/notice files in a source release for branch2.3 (these files only exist in master/branch-2.4 now), this pr checked a Spark release version in `dev/create-release/release-build.sh`. ## How was this patch tested? Manually checked. Closes apache#23538 from maropu/FixReleaseScript. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit abc937b) Signed-off-by: Sean Owen <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
… for branch-2.4+ only ## What changes were proposed in this pull request? To skip some steps to remove binary license/notice files in a source release for branch2.3 (these files only exist in master/branch-2.4 now), this pr checked a Spark release version in `dev/create-release/release-build.sh`. ## How was this patch tested? Manually checked. Closes apache#23538 from maropu/FixReleaseScript. Authored-by: Takeshi Yamamuro <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit abc937b) Signed-off-by: Sean Owen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To skip some steps to remove binary license/notice files in a source release for branch2.3 (these files only exist in master/branch-2.4 now), this pr checked a Spark release version in
dev/create-release/release-build.sh.How was this patch tested?
Manually checked.