[SPARK-26382][CORE] prefix comparator should handle -0.0 #23334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
Contributor
Author
cloud-fan
commented
Dec 17, 2018
Contributor
Author
There was a problem hiding this comment.
improve the test coverage a little bit.
Member
|
By reading the PR description, sounds that this change is not for addressing an existing bug but just a safer guard, right? |
viirya
approved these changes
Dec 17, 2018
HyukjinKwon
approved these changes
Dec 17, 2018
|
Test build #100231 has finished for PR 23334 at commit
|
|
Test build #100233 has finished for PR 23334 at commit
|
Contributor
Author
|
@viirya yes you are right |
Member
|
LGTM pending jenkins |
| */ | ||
| public static long computePrefix(double value) { | ||
| // normalize -0.0 to 0.0, as they should be equal | ||
| value = value == -0.0 ? 0.0 : value; |
Member
There was a problem hiding this comment.
Technically, value == -0.0 is true for both 0.0 and -0.0, but the current one is the simplest one for this normalization. We don't need to exclude 0.0 here. +1 for the logic.
Member
|
Shall we use |
dongjoon-hyun
changed the title
|
Test build #100243 has finished for PR 23334 at commit
|
Member
|
Although this is not a bug fix, can we have this in |
Contributor
Author
|
@kiszk good idea, updated #23239 @dongjoon-hyun I'm fine with it. Feel free to merge :) |
Member
|
Thank you, @cloud-fan and @viirya , @HyukjinKwon , @kiszk . |
asfgit
pushed a commit
that referenced
this pull request
Dec 18, 2018
## What changes were proposed in this pull request? This is kind of a followup of #23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes #23334 from cloud-fan/sort. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit befca98) Signed-off-by: Dongjoon Hyun <[email protected]>
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Jan 5, 2019
## What changes were proposed in this pull request? This is kind of a followup of apache#23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes apache#23334 from cloud-fan/sort. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This is kind of a followup of apache#23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes apache#23334 from cloud-fan/sort. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? This is kind of a followup of apache#23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes apache#23334 from cloud-fan/sort. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit befca98) Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? This is kind of a followup of apache#23239 The `UnsafeProject` will normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it. However, for consistency and future-proof, this PR proposes to normalize `-0.0` in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well. This is not a bug fix, but a safe guard. ## How was this patch tested? existing tests Closes apache#23334 from cloud-fan/sort. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit befca98) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is kind of a followup of #23239
The
UnsafeProjectwill normalize special float/double values(NaN and -0.0), so the sorter doesn't have to handle it.However, for consistency and future-proof, this PR proposes to normalize
-0.0in the prefix comparator, so that it's same with the normal ordering. Note that prefix comparator handles NaN as well.This is not a bug fix, but a safe guard.
How was this patch tested?
existing tests