[MINOR][SQL] Some errors in the notes. #23280
Conversation
|
It's okay but mind taking another look and fix some more typos together while we're here? I'm pretty sure there are more. |
| StructType(attrs.map(a => StructField(a.name, a.dataType, a.nullable, a.metadata))) | ||
| } | ||
|
|
||
| // It's possible that `attrs` is a linked list, which can lead to bad O(n^2) loops when |
There was a problem hiding this comment.
Could you tell us why you think this comment is error? This comments came from SPARK-15764 Replace N^2 loop in BindReferences to explain the problamatic situation.
When using ordinals to access linked list, the time cost is O(n).
There was a problem hiding this comment.
The cost time to access the linked list using ordinal is O (n), but I do not combine BindReferences to analyze the cost time.
There was a problem hiding this comment.
Ya. The original sentence has a different context at that time.
|
Test build #4464 has finished for PR 23280 at commit
|
|
Test build #4470 has finished for PR 23280 at commit
|
|
The merge error is spurious; merging to master |
## What changes were proposed in this pull request? When using ordinals to access linked list, the time cost is O(n). ## How was this patch tested? Existing tests. Closes apache#23280 from CarolinePeng/update_Two. Authored-by: CarolinPeng <[email protected]> Signed-off-by: Sean Owen <[email protected]>
## What changes were proposed in this pull request? When using ordinals to access linked list, the time cost is O(n). ## How was this patch tested? Existing tests. Closes apache#23280 from CarolinePeng/update_Two. Authored-by: CarolinPeng <[email protected]> Signed-off-by: Sean Owen <[email protected]>
5 participants
What changes were proposed in this pull request?
When using ordinals to access linked list, the time cost is O(n).
How was this patch tested?
Existing tests.