Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This PR aims to upgrade Janino compiler to the latest version 3.0.11. The followings are the changes from the release note.

  • Script with many "helper" variables.
  • Java 9+ compatibility
  • Compilation Error Messages Generated by JDK.
  • Added experimental support for the "StackMapFrame" attribute; not active yet.
  • Make Unparser more flexible.
  • Fixed NPEs in various "toString()" methods.
  • Optimize static method invocation with rvalue target expression.
  • Added all missing "ClassFile.getConstant*Info()" methods, removing the necessity for many type casts.

How was this patch tested?

Pass the Jenkins with the existing tests.

@SparkQA
Copy link

SparkQA commented Dec 7, 2018

Test build #99793 has finished for PR 23250 at commit 634104f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon . Merged to master.

@asfgit asfgit closed this in 4772265 Dec 7, 2018
@dongjoon-hyun dongjoon-hyun deleted the SPARK-26298 branch December 7, 2018 05:23
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

This PR aims to upgrade Janino compiler to the latest version 3.0.11. The followings are the changes from the [release note](http://janino-compiler.github.io/janino/changelog.html).

- Script with many "helper" variables.
- Java 9+ compatibility
- Compilation Error Messages Generated by JDK.
- Added experimental support for the "StackMapFrame" attribute; not active yet.
- Make Unparser more flexible.
- Fixed NPEs in various "toString()" methods.
- Optimize static method invocation with rvalue target expression.
- Added all missing "ClassFile.getConstant*Info()" methods, removing the necessity for many type casts.

## How was this patch tested?

Pass the Jenkins with the existing tests.

Closes apache#23250 from dongjoon-hyun/SPARK-26298.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants