Skip to content

[SPARK-26256][K8s] Fix labels for pod deletion #23209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-26256][K8s] Fix labels for pod deletion #23209

wants to merge 1 commit into from

Conversation

@skonto
Copy link
Contributor

@skonto skonto commented Dec 3, 2018

What changes were proposed in this pull request?

Adds proper labels when deleting executor pods.

How was this patch tested?

Manually with tests.

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Test build #99605 has finished for PR 23209 at commit c40f4df.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5675/

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5675/

liyinan926
liyinan926 approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skonto skonto force-pushed the fix-deletion-labels branch from c40f4df to 2510d3a Compare December 3, 2018 21:17
@skonto
Copy link
Contributor Author

skonto commented Dec 3, 2018

@srowen I resolved the conflicts feel free to merge.

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Test build #99626 has finished for PR 23209 at commit 2510d3a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5683/

@SparkQA
Copy link

SparkQA commented Dec 3, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5683/

@vanzin
Copy link
Contributor

vanzin commented Dec 3, 2018

Merging to master / 2.4.

@vanzin
Copy link
Contributor

vanzin commented Dec 3, 2018

Actually I forgot 2.4... there's also a conflict. Seems trivial, so I'll do it manually and fix the conflict (and run some local tests).

@asfgit asfgit closed this in a24e1a1 Dec 3, 2018
asfgit pushed a commit that referenced this pull request Dec 3, 2018
[SPARK-26256][K8S] Fix labels for pod deletion
349e25b 
Adds proper labels when deleting executor pods.

Manually with tests.

Closes #23209 from skonto/fix-deletion-labels.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
(cherry picked from commit a24e1a1)
Signed-off-by: Marcelo Vanzin <[email protected]>
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
[SPARK-26256][K8S] Fix labels for pod deletion
62f0a84 
## What changes were proposed in this pull request?
Adds proper labels when deleting executor pods.

## How was this patch tested?
Manually with tests.

Closes apache#23209 from skonto/fix-deletion-labels.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
@kai-chi
[SPARK-26256][K8S] Fix labels for pod deletion
bdea1e9 
Adds proper labels when deleting executor pods.

Manually with tests.

Closes apache#23209 from skonto/fix-deletion-labels.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
(cherry picked from commit a24e1a1)
Signed-off-by: Marcelo Vanzin <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
@kai-chi
[SPARK-26256][K8S] Fix labels for pod deletion
eb45976 
Adds proper labels when deleting executor pods.

Manually with tests.

Closes apache#23209 from skonto/fix-deletion-labels.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Marcelo Vanzin <[email protected]>
(cherry picked from commit a24e1a1)
Signed-off-by: Marcelo Vanzin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

+1 more reviewer

@liyinan926 liyinan926 liyinan926 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@skonto @SparkQA @vanzin @srowen @liyinan926