[SPARK-26033][SPARK-26034][PYTHON][FOLLOW-UP] Small cleanup and deduplication in ml/mllib tests #23200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @BryanCutler - it's a small minor followup. |
|
Test build #99569 has finished for PR 23200 at commit
|
Member
Author
|
retest this please |
|
Test build #99573 has finished for PR 23200 at commit
|
srowen
approved these changes
Dec 3, 2018
BryanCutler
approved these changes
Dec 3, 2018
| else: | ||
| return b.squared_distance(a) | ||
| from pyspark.testing.mllibutils import MLlibTestCase | ||
| from pyspark.testing.utils import have_scipy |
Member
There was a problem hiding this comment.
Oh that's good, didn't realize have_scipy was there
Member
|
merged to master, thanks @HyukjinKwon |
Member
Author
|
Thank you @srowen and @BryanCutler |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…lication in ml/mllib tests ## What changes were proposed in this pull request? This PR is a small follow up that puts some logic and functions into smaller scope and make it localized, and deduplicate. ## How was this patch tested? Manually tested. Jenkins tests as well. Closes apache#23200 from HyukjinKwon/followup-SPARK-26034-SPARK-26033. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Bryan Cutler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a small follow up that puts some logic and functions into smaller scope and make it localized, and deduplicate.
How was this patch tested?
Manually tested. Jenkins tests as well.