[MINOR][SQL] Combine the same codes in test cases #23194

CarolinePeng · 2018-12-01T08:11:08Z

What changes were proposed in this pull request?

In the DDLSuit, there are four test cases have the same codes , writing a function can combine the same code.

How was this patch tested?

existing tests.

kiszk · 2018-12-01T12:41:56Z

Good catch

kiszk · 2018-12-01T12:42:02Z

ok to test

kiszk · 2018-12-01T12:42:30Z

core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala

Is this change related to this PR?

No, I think it can be modified here,so I changed it by the way.

kiszk · 2018-12-01T12:42:43Z

core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala

SparkQA · 2018-12-01T16:04:26Z

Test build #99551 has finished for PR 23194 at commit eff036c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2018-12-03T07:29:30Z

Test build #99587 has finished for PR 23194 at commit 126ca0d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

heary-cao · 2018-12-03T10:14:18Z

LGTM, cc @HyukjinKwon.

maropu · 2018-12-03T12:53:38Z

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala

How about withEmptyDirInTablePath(dirName: String)?

Ok,thank you !

maropu · 2018-12-03T12:53:49Z

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala

nit: try {

maropu · 2018-12-03T12:54:22Z

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala

nit: revert this

maropu · 2018-12-04T04:31:13Z

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala

maropu · 2018-12-04T04:31:33Z

LGTM except for minor comments

SparkQA · 2018-12-04T06:51:04Z

Test build #99644 has finished for PR 23194 at commit 867ee5e.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2018-12-04T07:20:53Z

Test build #99649 has finished for PR 23194 at commit 877751b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

SparkQA · 2018-12-04T08:05:02Z

Test build #99652 has finished for PR 23194 at commit ac2b004.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

heary-cao · 2018-12-04T09:25:00Z

retest this please

SparkQA · 2018-12-04T12:57:14Z

Test build #99656 has finished for PR 23194 at commit ac2b004.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

maropu · 2018-12-04T13:11:32Z

thanks, merging to master!

## What changes were proposed in this pull request? In the DDLSuit, there are four test cases have the same codes , writing a function can combine the same code. ## How was this patch tested? existing tests. Closes apache#23194 from CarolinePeng/Update_temp. Authored-by: 彭灿00244106 <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]>

kiszk reviewed Dec 1, 2018

View reviewed changes

core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala Outdated

Copy link

Member

kiszk Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

CarolinePeng force-pushed the Update_temp branch from eff036c to 126ca0d Compare December 3, 2018 04:01

maropu reviewed Dec 3, 2018

View reviewed changes

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala Outdated

Copy link

Member

maropu Dec 3, 2018 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: try {

maropu reviewed Dec 3, 2018

View reviewed changes

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala Outdated

Copy link

Member

maropu Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: revert this

srowen approved these changes Dec 3, 2018

View reviewed changes

CarolinePeng force-pushed the Update_temp branch from 126ca0d to 867ee5e Compare December 4, 2018 03:47

maropu reviewed Dec 4, 2018

View reviewed changes

sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala Outdated

Copy link

Member

maropu Dec 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private?

CarolinePeng force-pushed the Update_temp branch from 867ee5e to 877751b Compare December 4, 2018 05:34

update some codes

ac2b004

CarolinePeng force-pushed the Update_temp branch from 877751b to ac2b004 Compare December 4, 2018 07:21

asfgit closed this in 93f5592 Dec 4, 2018

[MINOR][SQL] Combine the same codes in test cases #23194

[MINOR][SQL] Combine the same codes in test cases #23194

Uh oh!

Conversation

CarolinePeng commented Dec 1, 2018

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

kiszk commented Dec 1, 2018

Uh oh!

kiszk commented Dec 1, 2018

Uh oh!

kiszk Dec 1, 2018

Choose a reason for hiding this comment

Uh oh!

CarolinePeng Dec 1, 2018

Choose a reason for hiding this comment

Uh oh!

kiszk Dec 1, 2018

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Dec 1, 2018

Uh oh!

SparkQA commented Dec 3, 2018

Uh oh!

heary-cao commented Dec 3, 2018

Uh oh!

maropu Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

CarolinePeng Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

maropu Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maropu Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

maropu Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

maropu commented Dec 4, 2018

Uh oh!

SparkQA commented Dec 4, 2018

Uh oh!

SparkQA commented Dec 4, 2018

Uh oh!

SparkQA commented Dec 4, 2018

Uh oh!

heary-cao commented Dec 4, 2018

Uh oh!

SparkQA commented Dec 4, 2018

Uh oh!

maropu commented Dec 4, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

maropu Dec 3, 2018 •

edited

Loading