[SPARK-26117][FOLLOW-UP][SQL]throw SparkOutOfMemoryError intead of SparkException in UnsafeHashedRelation #23190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #99534 has finished for PR 23190 at commit
|
heary-cao
force-pushed
the
throwUnsafeHashedRelation
branch
from
8046944 to
92eb086
Compare
|
Test build #99540 has finished for PR 23190 at commit
|
heary-cao
force-pushed
the
throwUnsafeHashedRelation
branch
from
92eb086 to
3376524
Compare
|
Test build #99541 has finished for PR 23190 at commit
|
heary-cao
force-pushed
the
throwUnsafeHashedRelation
branch
from
3376524 to
5b39ed3
Compare
|
Test build #99548 has finished for PR 23190 at commit
|
Contributor
Author
|
retest this please |
|
Test build #99554 has finished for PR 23190 at commit
|
heary-cao
force-pushed
the
throwUnsafeHashedRelation
branch
from
5b39ed3 to
87c567d
Compare
|
Test build #99557 has finished for PR 23190 at commit
|
Contributor
|
retest this please |
Contributor
|
LGTM |
Member
|
retest this please |
Member
|
Is this follow-up of #23084? |
kiszk
reviewed
Dec 3, 2018
Member
|
LGTM except two comments |
heary-cao
force-pushed
the
throwUnsafeHashedRelation
branch
from
87c567d to
44b9e03
Compare
heary-cao
changed the title
|
Test build #99582 has finished for PR 23190 at commit
|
|
Test build #99584 has finished for PR 23190 at commit
|
gatorsmile
reviewed
Dec 3, 2018
Member
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
Please change the PR title to [SPARK-26117] [FOLLOW-UP][SQL]throw SparkOutOfMemoryError intead of SparkException in UnsafeHashedRelation
heary-cao
changed the title
heary-cao
changed the title
Contributor
|
thanks, merging to master! |
Contributor
Author
|
thanks, @cloud-fan @gatorsmile @kiszk. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
…parkException in UnsafeHashedRelation ## What changes were proposed in this pull request? When build hash Map with one row of data and run out of memory, we should throw a SparkOutOfMemoryError exception, which is more accurate than SparkException. this PR fix it. ## How was this patch tested? N / A Closes apache#23190 from heary-cao/throwUnsafeHashedRelation. Authored-by: caoxuewen <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When build hash Map with one row of data and run out of memory, we should throw a SparkOutOfMemoryError exception, which is more accurate than SparkException. this PR fix it.
How was this patch tested?
N / A