Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Nov 13, 2018

What changes were proposed in this pull request?

Remove *.crc from .gitignore as there are actual .crc files in the test source dirs and IJ warns about it

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Nov 13, 2018

Test build #98758 has finished for PR 23020 at commit 494eb2c.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Nov 13, 2018

Test build #98764 has finished for PR 23020 at commit 494eb2c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member Author

srowen commented Nov 13, 2018

Merged to master

@asfgit asfgit closed this in 1148261 Nov 13, 2018
@srowen srowen deleted the gitignore branch November 14, 2018 20:53
@HeartSaVioR
Copy link
Contributor

@srowen
Looks like there're two cases for crc files in test resources, whether automatically created or not.

#22170 was to prevent the case for adding sql/core/src/test/resources/.?.delta.crc to repo (on reflecting review comment in #21733), but there're other crc files for parquet test files.

After this PR I have to narrow down ranges when executing git add against sql/core.

Maybe adding sql/core/src/test/resources/.?.delta.crc to .gitignore helps? With the change we can narrow down the actual things to ignore. If it makes sense I'll craft a quick fix.

@srowen
Copy link
Member Author

srowen commented Jan 3, 2019

@HeartSaVioR that could be fine, but what is the problem? I'm not clear. Files that are in git should not be covered by ignore rules. .crc files that are created by tests should be ignored, but they should be under target/ which is already ignored.

@HeartSaVioR
Copy link
Contributor

@srowen
Never mind. Looks like I added these files to #22170 but forgot to delete them. This patch made them reappear. Sorry for false alarming.

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

Remove *.crc from .gitignore as there are actual .crc files in the test source dirs and IJ warns about it

## How was this patch tested?

N/A

Closes apache#23020 from srowen/gitignore.

Authored-by: Sean Owen <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants