[SPARK-26003] Improve SQLAppStatusListener.aggregateMetrics performance #23002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #98683 has finished for PR 23002 at commit
|
Contributor
Author
Contributor
|
LGTM, also cc @gengliangwang |
|
|
||
| private def aggregateMetrics(exec: LiveExecutionData): Map[Long, String] = { | ||
| val metricIds = exec.metrics.map(_.accumulatorId).sorted | ||
| val metricIds = exec.metrics.map(_.accumulatorId).toSet |
Member
There was a problem hiding this comment.
Actually this one can be merged into metricTypes.
| val metricIds = exec.metrics.map(_.accumulatorId).toSet | ||
| val metricTypes = exec.metrics.map { m => (m.accumulatorId, m.metricType) }.toMap | ||
| val metrics = exec.stages.toSeq | ||
| .flatMap { stageId => Option(stageMetrics.get(stageId)) } |
Member
There was a problem hiding this comment.
Consider also change the following flatMap / filter / groupBy into while loop
Contributor
Author
There was a problem hiding this comment.
not sure what you mean here. Why should we use a while loop?
Member
There was a problem hiding this comment.
If the metrics is large, then using a while loop can reduce the number of traversal loops. And it is not complicated to do it in the code here.
Member
There was a problem hiding this comment.
I am also fine with the current code here.
Contributor
Author
There was a problem hiding this comment.
yes, we can save 1 traversal, but I am not sure it is worth honestly... This approach seems cleaner to me.
|
Test build #98730 has finished for PR 23002 at commit
|
Contributor
|
thanks, merging to master! |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? In `SQLAppStatusListener.aggregateMetrics`, we use the `metricIds` only to filter the relevant metrics. And this is a Seq which is also sorted. When there are many metrics involved, this can be pretty inefficient. The PR proposes to use a Set for it. ## How was this patch tested? NA Closes apache#23002 from mgaido91/SPARK-26003. Authored-by: Marco Gaido <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
gatorsmile
pushed a commit
to gatorsmile/spark
that referenced
this pull request
Sep 19, 2019
## What changes were proposed in this pull request? In `SQLAppStatusListener.aggregateMetrics`, we use the `metricIds` only to filter the relevant metrics. And this is a Seq which is also sorted. When there are many metrics involved, this can be pretty inefficient. The PR proposes to use a Set for it. ## How was this patch tested? NA Closes apache#23002 from mgaido91/SPARK-26003. Authored-by: Marco Gaido <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 20, 2019
… performance This PR is to cherry-pick #23002 to Spark 2.4 --- ## What changes were proposed in this pull request? In `SQLAppStatusListener.aggregateMetrics`, we use the `metricIds` only to filter the relevant metrics. And this is a Seq which is also sorted. When there are many metrics involved, this can be pretty inefficient. The PR proposes to use a Set for it. ## How was this patch tested? NA Closes #23002 from mgaido91/SPARK-26003. Closes #25860 from gatorsmile/cherrypickSPARK-26003. Authored-by: Marco Gaido <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
SQLAppStatusListener.aggregateMetrics, we use themetricIdsonly to filter the relevant metrics. And this is a Seq which is also sorted. When there are many metrics involved, this can be pretty inefficient. The PR proposes to use a Set for it.How was this patch tested?
NA