[minor] update HiveExternalCatalogVersionsSuite to test 2.4.0 #22984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
Contributor
Author
cloud-fan
commented
Nov 8, 2018
| object PROCESS_TABLES extends QueryTest with SQLTestUtils { | ||
| // Tests the latest version of every release line. | ||
| val testingVersions = Seq("2.1.3", "2.2.2", "2.3.2") | ||
| val testingVersions = Seq("2.1.3", "2.2.2", "2.3.2", "2.4.0") |
Contributor
Author
There was a problem hiding this comment.
when will we drop 2.1 officially?
Member
There was a problem hiding this comment.
2.1 should be removed actually. At least according to our default 18-month support rule, it ended support in June 2018, and I see no desire for a 2.1.4 release. 2.2 will end in Jan 2019 according to the same guideline. It's not a hard rule, but probably the right guidance to follow.
Certainly, as this test takes a while and can be flaky I'd like to keep it to 3 versions.
|
Test build #98608 has finished for PR 22984 at commit
|
|
Test build #98604 has finished for PR 22984 at commit
|
dongjoon-hyun
approved these changes
Nov 8, 2018
Member
|
Retest this please. |
|
Test build #98617 has finished for PR 22984 at commit
|
Member
|
It's an irrelevant failure. |
Member
|
Retest this please. |
|
Test build #98626 has finished for PR 22984 at commit
|
Member
|
Thank you, @cloud-fan and @srowen . Merged to master/branch-2.4. |
asfgit
pushed a commit
that referenced
this pull request
Nov 8, 2018
## What changes were proposed in this pull request? Since Spark 2.4.0 is released, we should test it in HiveExternalCatalogVersionsSuite ## How was this patch tested? N/A Closes #22984 from cloud-fan/minor. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 973f7c0) Signed-off-by: Dongjoon Hyun <[email protected]>
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? Since Spark 2.4.0 is released, we should test it in HiveExternalCatalogVersionsSuite ## How was this patch tested? N/A Closes apache#22984 from cloud-fan/minor. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Jul 23, 2019
## What changes were proposed in this pull request? Since Spark 2.4.0 is released, we should test it in HiveExternalCatalogVersionsSuite ## How was this patch tested? N/A Closes apache#22984 from cloud-fan/minor. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 973f7c0) Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Aug 1, 2019
## What changes were proposed in this pull request? Since Spark 2.4.0 is released, we should test it in HiveExternalCatalogVersionsSuite ## How was this patch tested? N/A Closes apache#22984 from cloud-fan/minor. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 973f7c0) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since Spark 2.4.0 is released, we should test it in HiveExternalCatalogVersionsSuite
How was this patch tested?
N/A