Skip to content

Conversation

@skonto
Copy link
Contributor

@skonto skonto commented Nov 2, 2018

What changes were proposed in this pull request?

  • Issue is described in detail in SPARK-25930. Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests.

How was this patch tested?

manually. rm -rf ~/.m2 and then run the tests.

@skonto
Copy link
Contributor Author

skonto commented Nov 2, 2018

@srowen pls review. We missed that, kind of tricky. Making mvn silent is not that easy from what I checked, now I think this is robust enough.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98409 has finished for PR 22931 at commit 913b4c4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4725/

@shaneknapp
Copy link
Contributor

test this please

@vanzin
Copy link
Contributor

vanzin commented Nov 2, 2018

This is what make-distribution.sh uses, perhaps do the same here?

(It also has a slight advantage of not hardcoding the version of the plugin.)

SCALA_VERSION=$("$MVN" help:evaluate -Dexpression=scala.binary.version $TRIMMED_ARGS 2>/dev/null\
    | grep -v "INFO"\
    | grep -v "WARNING"\
    | tail -n 1)

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98410 has finished for PR 22931 at commit 913b4c4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4726/

@skonto
Copy link
Contributor Author

skonto commented Nov 2, 2018

@vanzin ok let me try that. I dont need $TRIMMED_ARGS

@shaneknapp
Copy link
Contributor

shaneknapp commented Nov 2, 2018

btw next k8s test that runs will actually have logs archived for the build!

here's the integration test log from this run, which wasn't archived...
integration-tests.log

@skonto skonto force-pushed the fix_scala_detection branch from 913b4c4 to bf85974 Compare November 2, 2018 21:04
@skonto
Copy link
Contributor Author

skonto commented Nov 2, 2018

@vanzin modified it. Much better.

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Test build #98412 has finished for PR 22931 at commit bf85974.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 2, 2018

OK. Does this need to go in branch 2.4 too?

@SparkQA
Copy link

SparkQA commented Nov 2, 2018

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4727/

@shaneknapp
Copy link
Contributor

sorry, ignore amplab's report. the build passed, but my hacking on the integration test reports was what caused the failure.

@skonto
Copy link
Contributor Author

skonto commented Nov 2, 2018

@srowen yes.

@SparkQA
Copy link

SparkQA commented Nov 4, 2018

Test build #4412 has finished for PR 22931 at commit bf85974.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Nov 5, 2018
## What changes were proposed in this pull request?

- Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests.

## How was this patch tested?
manually. rm -rf ~/.m2 and then run the tests.

Closes #22931 from skonto/fix_scala_detection.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
(cherry picked from commit 1fb3759)
Signed-off-by: Sean Owen <[email protected]>
@srowen
Copy link
Member

srowen commented Nov 5, 2018

Merged to master/2.4

@asfgit asfgit closed this in 1fb3759 Nov 5, 2018
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

- Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests.

## How was this patch tested?
manually. rm -rf ~/.m2 and then run the tests.

Closes apache#22931 from skonto/fix_scala_detection.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Jul 23, 2019
## What changes were proposed in this pull request?

- Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests.

## How was this patch tested?
manually. rm -rf ~/.m2 and then run the tests.

Closes apache#22931 from skonto/fix_scala_detection.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
(cherry picked from commit 1fb3759)
Signed-off-by: Sean Owen <[email protected]>
kai-chi pushed a commit to kai-chi/spark that referenced this pull request Aug 1, 2019
## What changes were proposed in this pull request?

- Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests.

## How was this patch tested?
manually. rm -rf ~/.m2 and then run the tests.

Closes apache#22931 from skonto/fix_scala_detection.

Authored-by: Stavros Kontopoulos <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
(cherry picked from commit 1fb3759)
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants