-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-25930][K8s] Fix scala string detection in k8s tests #22931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@srowen pls review. We missed that, kind of tricky. Making mvn silent is not that easy from what I checked, now I think this is robust enough. |
|
Kubernetes integration test starting |
|
Test build #98409 has finished for PR 22931 at commit
|
|
Kubernetes integration test status success |
|
test this please |
|
This is what make-distribution.sh uses, perhaps do the same here? (It also has a slight advantage of not hardcoding the version of the plugin.) |
|
Kubernetes integration test starting |
|
Test build #98410 has finished for PR 22931 at commit
|
|
Kubernetes integration test status success |
|
@vanzin ok let me try that. I dont need |
|
btw next k8s test that runs will actually have logs archived for the build! here's the integration test log from this run, which wasn't archived... |
913b4c4 to
bf85974
Compare
|
@vanzin modified it. Much better. |
|
Kubernetes integration test starting |
|
Test build #98412 has finished for PR 22931 at commit
|
|
OK. Does this need to go in branch 2.4 too? |
|
Kubernetes integration test status success |
|
sorry, ignore amplab's report. the build passed, but my hacking on the integration test reports was what caused the failure. |
|
@srowen yes. |
|
Test build #4412 has finished for PR 22931 at commit
|
## What changes were proposed in this pull request? - Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests. ## How was this patch tested? manually. rm -rf ~/.m2 and then run the tests. Closes #22931 from skonto/fix_scala_detection. Authored-by: Stavros Kontopoulos <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 1fb3759) Signed-off-by: Sean Owen <[email protected]>
|
Merged to master/2.4 |
## What changes were proposed in this pull request? - Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests. ## How was this patch tested? manually. rm -rf ~/.m2 and then run the tests. Closes apache#22931 from skonto/fix_scala_detection. Authored-by: Stavros Kontopoulos <[email protected]> Signed-off-by: Sean Owen <[email protected]>
## What changes were proposed in this pull request? - Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests. ## How was this patch tested? manually. rm -rf ~/.m2 and then run the tests. Closes apache#22931 from skonto/fix_scala_detection. Authored-by: Stavros Kontopoulos <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 1fb3759) Signed-off-by: Sean Owen <[email protected]>
## What changes were proposed in this pull request? - Issue is described in detail in [SPARK-25930](https://issues.apache.org/jira/browse/SPARK-25930). Since we rely on the std output, pick always the last line which contains the wanted value. Although minor, current implementation breaks tests. ## How was this patch tested? manually. rm -rf ~/.m2 and then run the tests. Closes apache#22931 from skonto/fix_scala_detection. Authored-by: Stavros Kontopoulos <[email protected]> Signed-off-by: Sean Owen <[email protected]> (cherry picked from commit 1fb3759) Signed-off-by: Sean Owen <[email protected]>
What changes were proposed in this pull request?
How was this patch tested?
manually. rm -rf ~/.m2 and then run the tests.