Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Oct 29, 2018

What changes were proposed in this pull request?

Add an optimizer tracker for TPC-DS queries. For example:

  1. Add InferFiltersFromConstraints and PushDownPredicate to RewriteSubquery optimizer. All affected queries: 5e124fa
  2. Add InferFiltersFromConstraints, PushDownPredicate and CombineFilters to RewriteSubquery optimizer. All affected queries: d3b11ab

How was this patch tested?

manual tests

@kiszk
Copy link
Member

kiszk commented Oct 29, 2018

cc @maropu

@SparkQA
Copy link

SparkQA commented Oct 29, 2018

Test build #98222 has finished for PR 22879 at commit d8e8a96.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gatorsmile
Copy link
Member

For generating the golden files, I would not generate the whole plan. Instead, we can keep the node name. That should be good enough.

@yucai
Copy link
Contributor

yucai commented Oct 31, 2018

tpcdsQueries and tpcdsQueriesV2_7 are duplicated to TPCDSQueryBenchmark's, should we maintain them together?

@wangyum
Copy link
Member Author

wangyum commented Oct 31, 2018

@yucai make sense. Maybe we can also reuse setupTables with TPCDSQuerySuite.

@SparkQA
Copy link

SparkQA commented Nov 5, 2018

Test build #98464 has finished for PR 22879 at commit 029f468.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants