-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-25785][SQL] Add prettyNames for from_json, to_json, from_csv, and schema_of_json #22773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #97591 has finished for PR 22773 at commit
|
|
retest this please |
|
Test build #97599 has finished for PR 22773 at commit
|
|
retest this please. |
|
LGTM |
|
Test build #97604 has finished for PR 22773 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, but could you make this as a follow-up for the existing issues or create a new one?
|
Other JIRAs have different fixed versions. Let me create a new JIRA then. |
|
Merged to master. |
|
Thank you @viirya and @dongjoon-hyun. |
|
This is an external change. This needs a migration guide update. Column names in schema are changed by this PR |
|
That's the exact issue I raised before and we ended up with not keeping the compatibility in column names. @cloud-fan and @hvanhovell. |
|
BTW, it's closer to bug rather then improvement tho. |
|
I think the new names are better and expected, though it's safer to mention it in the migration guide in case some users care about it. |
|
My impression so far was that we note things at migration notes when they are improvements (not bugs), and non-trivial and related to backward compatibility. Shall we clarify what to document at migration guide? Otherwise we should document everything related with, let's say, all external changes, deprecation removal, trivial changes, and many other changes related with column names. |
|
All the things that could break the existing user applications should be documented in the migration guide. This will simplify the system upgrade of our end users. |
|
Sure, so for clarification, we will document everything that could break external users applications in any way, right? |
|
Yes. The goal of migration guide is for helping end users upgrade their Spark. |
|
Yup, will encourage to update the migration guide in that way. |
…and schema_of_json ## What changes were proposed in this pull request? This PR adds `prettyNames` for `from_json`, `to_json`, `from_csv`, and `schema_of_json` so that appropriate names are used. ## How was this patch tested? Unit tests Closes apache#22773 from HyukjinKwon/minor-prettyNames. Authored-by: hyukjinkwon <[email protected]> Signed-off-by: hyukjinkwon <[email protected]>
What changes were proposed in this pull request?
This PR adds
prettyNamesforfrom_json,to_json,from_csv, andschema_of_jsonso that appropriate names are used.How was this patch tested?
Unit tests