Skip to content

Conversation

@gatorsmile
Copy link
Member

What changes were proposed in this pull request?

This is a follow up of #22574. Renamed the parameter and added comments.

How was this patch tested?

N/A

@gatorsmile
Copy link
Member Author

cc @dbtsai @cloud-fan

@dbtsai
Copy link
Member

dbtsai commented Oct 9, 2018

LGTM. Wait for the PR build. Thanks.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@SparkQA
Copy link

SparkQA commented Oct 9, 2018

Test build #97167 has finished for PR 22679 at commit 3840d44.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dbtsai
Copy link
Member

dbtsai commented Oct 9, 2018

Thanks. Merged into master.

@asfgit asfgit closed this in faf73dc Oct 9, 2018
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
…ts in Parquet

## What changes were proposed in this pull request?
This is a follow up of apache#22574. Renamed the parameter and added comments.

## How was this patch tested?
N/A

Closes apache#22679 from gatorsmile/followupSPARK-25559.

Authored-by: gatorsmile <[email protected]>
Signed-off-by: DB Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants