[SPARK-3395] [SQL] DSL sometimes incorrectly reuses attribute ids, breaking queries

[ericl]

This resolves https://issues.apache.org/jira/browse/SPARK-3395

[AmplabJenkins]

Can one of the admins verify this patch?

[marmbrus]

ok to test

[SparkQA]

QA tests have started for PR 2266 at commit 05bd1e4.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2266 at commit 05bd1e4.

• This patch fails unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • class BlockManagerMaster(
  • class AttributeMap[A](baseMap: Map[ExprId, (Attribute, A)])

[ericl]

added regression test in DslQuerySuite

[marmbrus]

test this please

[SparkQA]

QA tests have started for PR 2266 at commit 7f2b6f0.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2266 at commit 7f2b6f0.

• This patch fails unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

Jenkins, test this please.

[SparkQA]

QA tests have started for PR 2266 at commit 7f2b6f0.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 2266 at commit 7f2b6f0.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[marmbrus]

Thanks! Merged to master.