[SPARK-25630][TEST] Reduce test time of HadoopFsRelationTest #22643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #97000 has finished for PR 22643 at commit
|
| } else { | ||
| "" | ||
| } | ||
| test(s"test all data types - $dataType$extraMessage") { |
Member
There was a problem hiding this comment.
This PR accidentally seems to disable parquet.enable.dictionary = true cases even in ParquetHadoopFsRelationSuite. Could you fix that? After fixing that, we need to measure the time redunction again.
[info] ParquetHadoopFsRelationSuite:
[info] - test all data types - StringType (830 milliseconds)
...
gatorsmile
reviewed
Oct 5, 2018
| // more cores, the issue can be reproduced steadily. Fortunately our Jenkins builder meets this | ||
| // requirement. We probably want to move this test case to spark-integration-tests or spark-perf | ||
| // later. | ||
| test("SPARK-8406: Avoids name collision while writing files") { |
Member
There was a problem hiding this comment.
Just move this to ParquetHadoopFsRelationSuite.scala
|
Test build #97052 has finished for PR 22643 at commit
|
Member
Author
|
retest this please. |
|
Test build #97068 has finished for PR 22643 at commit
|
Member
Author
|
@dongjoon-hyun please take another look, thanks! |
Member
|
LGTM Thanks! Merged to master. |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? There was 5 suites extends `HadoopFsRelationTest`, for testing "orc"/"parquet"/"text"/"json" data sources. This PR refactor the base trait `HadoopFsRelationTest`: 1. Rename unnecessary loop for setting parquet conf 2. The test case `SPARK-8406: Avoids name collision while writing files` takes about 14 to 20 seconds. As now all the file format data source are using common code, for creating result files, we can test one data source(Parquet) only to reduce test time. To run related 5 suites: ``` ./build/sbt "hive/testOnly *HadoopFsRelationSuite" ``` The total test run time is reduced from 5 minutes 40 seconds to 3 minutes 50 seconds. ## How was this patch tested? Unit test Closes apache#22643 from gengliangwang/refactorHadoopFsRelationTest. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: gatorsmile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There was 5 suites extends
HadoopFsRelationTest, for testing "orc"/"parquet"/"text"/"json" data sources.This PR refactor the base trait
HadoopFsRelationTest:SPARK-8406: Avoids name collision while writing filestakes about 14 to 20 seconds. As now all the file format data source are using common code, for creating result files, we can test one data source(Parquet) only to reduce test time.To run related 5 suites:
The total test run time is reduced from 5 minutes 40 seconds to 3 minutes 50 seconds.
How was this patch tested?
Unit test