Skip to content

[SPARK-25568][Core]Continue to update the remaining accumulators when failing to update one accumulator #22586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[SPARK-25568][Core]Continue to update the remaining accumulators when failing to update one accumulator #22586

wants to merge 5 commits into from

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Sep 28, 2018

What changes were proposed in this pull request?

Since we don't fail a job when AccumulatorV2.merge fails, we should try to update the remaining accumulators so that they can still report correct values.

How was this patch tested?

The new unit test.

@SparkQA
Copy link

SparkQA commented Sep 29, 2018

Test build #96777 has finished for PR 22586 at commit e33788e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 29, 2018

Test build #96776 has finished for PR 22586 at commit badb471.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 29, 2018

Test build #96778 has finished for PR 22586 at commit a3d4a0d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 29, 2018

Test build #96779 has finished for PR 22586 at commit f582c34.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

gatorsmile
gatorsmile reviewed Sep 29, 2018
View reviewed changes
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala
assert(sc.parallelize(1 to 10, 2).count() === 10)
}

test("misbehaved accumulator should not impact other accumulators") {
Copy link
Member

@gatorsmile gatorsmile Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verify the log message?

See the example: https://github.com/apache/spark/blob/master/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/OptimizerLoggingSuite.scala#L41-L52

Copy link
Member Author

@zsxwing zsxwing Sep 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also verify the log message?

That's not in the core project.

@gatorsmile
Copy link
Member

gatorsmile commented Sep 29, 2018

LGTM

cc @cloud-fan

@gatorsmile
Copy link
Member

gatorsmile commented Sep 29, 2018

This was introduced by AccumulatorV2. It might be a blocker issue for Spark 2.4, since this could return an incorrect result.

HeartSaVioR
HeartSaVioR approved these changes Sep 29, 2018
View reviewed changes
Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this patch, and follow-up issue (SPARK-25569) totally makes sense to me.

asfgit pushed a commit that referenced this pull request Sep 30, 2018
@zsxwing @gatorsmile
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
6f510c6 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes #22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)
Signed-off-by: gatorsmile <[email protected]>
asfgit pushed a commit that referenced this pull request Sep 30, 2018
@zsxwing @gatorsmile
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
73408f0 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes #22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)
Signed-off-by: gatorsmile <[email protected]>
asfgit pushed a commit that referenced this pull request Sep 30, 2018
@zsxwing @gatorsmile
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
5dd14f5 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes #22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)
Signed-off-by: gatorsmile <[email protected]>
@asfgit asfgit closed this in b6b8a66 Sep 30, 2018
@gatorsmile
Copy link
Member

gatorsmile commented Sep 30, 2018

Thanks! Merged to master/2.4/2.3/2.2

@zsxwing zsxwing deleted the SPARK-25568 branch October 1, 2018 18:01
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
@zsxwing
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
ea4001a 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes apache#22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
Willymontaz pushed a commit to criteo-forks/spark that referenced this pull request Sep 26, 2019
@zsxwing
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
ab13b42 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes apache#22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)
Signed-off-by: gatorsmile <[email protected]>
Willymontaz pushed a commit to criteo-forks/spark that referenced this pull request Sep 27, 2019
@zsxwing @Willymontaz
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
890e088 
…n failing to update one accumulator

## What changes were proposed in this pull request?

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

## How was this patch tested?

The new unit test.

Closes apache#22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)
Signed-off-by: gatorsmile <[email protected]>
otterc pushed a commit to linkedin/spark that referenced this pull request Mar 22, 2023
@zsxwing @zoelin7
[SPARK-25568][CORE] Continue to update the remaining accumulators whe…
92db56d 
…n failing to update one accumulator

Ref: LIHADOOP-42001

Since we don't fail a job when `AccumulatorV2.merge` fails, we should try to update the remaining accumulators so that they can still report correct values.

The new unit test.

Closes apache#22586 from zsxwing/SPARK-25568.

Authored-by: Shixiong Zhu <[email protected]>
Signed-off-by: gatorsmile <[email protected]>
(cherry picked from commit b6b8a66)

RB=1489248
BUG=LIHADOOP-42001
G=superfriends-reviewers
R=fli,mshen,yezhou,edlu
A=yezhou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gatorsmile gatorsmile gatorsmile left review comments

@HeartSaVioR HeartSaVioR HeartSaVioR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zsxwing @SparkQA @gatorsmile @HeartSaVioR